Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support max backups of SLA data files #81

Merged
merged 3 commits into from
May 15, 2022
Merged

Support max backups of SLA data files #81

merged 3 commits into from
May 15, 2022

Conversation

haoel
Copy link
Contributor

@haoel haoel commented May 14, 2022 •
edited
Loading

Support to configure the max of SLA data file backups. default: 5
If set to a negative value, keep all backup files

  sla:
    data: /tmp/data/data.yaml
    backups: 20

keep addressing the issue #69

@haoel haoel requested review from proditis and zhao-kun May 14, 2022 07:43
proditis
proditis reviewed May 14, 2022
View reviewed changes
Copy link
Collaborator

@proditis proditis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Great work @haoel as always

probe/data.go Show resolved Hide resolved
@haoel haoel requested a review from proditis May 15, 2022 01:43
@haoel haoel merged commit 3413f12 into megaease:main May 15, 2022
@haoel haoel mentioned this pull request May 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhao-kun zhao-kun zhao-kun approved these changes

@proditis proditis Awaiting requested review from proditis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@haoel @proditis @zhao-kun