Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the Unit Test for conf package & HTTP Probe #199

Merged
merged 1 commit into from
Aug 23, 2022

Conversation

haoel
Copy link
Contributor

@haoel haoel commented Aug 23, 2022

  • Fix Unit Test failed on Windows platform - Windows platform seems to leave the removed files a while, which could sometimes cause the unit test to fail.

  • Add the UT for HTTP probe - test coverage to 100%

@codecov-commenter
Copy link

codecov-commenter commented Aug 23, 2022

Codecov Report

Base: 99.33% // Head: 99.51% // Increases project coverage by +0.17% 🎉

Coverage data is based on head (4c0fa3f) compared to base (882a021).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #199      +/-   ##
==========================================
+ Coverage   99.33%   99.51%   +0.17%     
==========================================
  Files          48       49       +1     
  Lines        4085     4088       +3     
==========================================
+ Hits         4058     4068      +10     
+ Misses         16       12       -4     
+ Partials       11        8       -3     
Impacted Files Coverage Δ
daemon/daemon_linux.go 100.00% <0.00%> (ø)
probe/http/http.go 100.00% <0.00%> (+3.41%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zhao-kun zhao-kun merged commit fb8ad1a into megaease:main Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants