Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change the getInt() and getFloat() to generic function #173

Merged
merged 3 commits into from
Jul 21, 2022
Merged

change the getInt() and getFloat() to generic function #173

merged 3 commits into from
Jul 21, 2022

Conversation

haoel
Copy link
Contributor

@haoel haoel commented Jul 20, 2022

No description provided.

@haoel haoel requested review from localvar and zhao-kun July 20, 2022 13:51
localvar
localvar approved these changes Jul 21, 2022
View reviewed changes
Copy link
Collaborator

@localvar localvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with the code changes, but I think the prior version is simpler and more explicit.

@zhao-kun zhao-kun merged commit e7f7521 into megaease:main Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@localvar localvar localvar approved these changes

@zhao-kun zhao-kun zhao-kun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@haoel @localvar @zhao-kun