Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug-fix: Lark(Feishu) notifications don't work #170

Merged
merged 1 commit into from
Jul 17, 2022
Merged

Conversation

xhkyyy
Copy link
Contributor

@xhkyyy xhkyyy commented Jul 16, 2022

This PR fix fails to send a notification to Lark(Feishu): code: 9499, msg: bad request.
This error is found in the Feishu document: https://open.feishu.cn/document/ukTMukTMukTM/ugjM14COyUjL4ITN

@haoel
Copy link
Contributor

haoel commented Jul 16, 2022

Thanks for this PR. So, the root cause is that the request body's JSON is invalid because of lacking the quotes, right?

@codecov-commenter
Copy link

codecov-commenter commented Jul 16, 2022

Codecov Report

Merging #170 (1df5899) into main (8b5be29) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #170   +/-   ##
=======================================
  Coverage   93.15%   93.15%           
=======================================
  Files          46       46           
  Lines        3362     3362           
=======================================
  Hits         3132     3132           
  Misses        161      161           
  Partials       69       69           
Impacted Files Coverage Δ
report/result.go 92.85% <100.00%> (ø)
report/sla.go 94.06% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b5be29...1df5899. Read the comment docs.

@xhkyyy
Copy link
Contributor Author

xhkyyy commented Jul 17, 2022

Thanks for this PR. So, the root cause is that the request body's JSON is invalid because of lacking the quotes, right?

@haoel yes, and the StatusCode check is also wrong, it causes always an error value to be returned instead of nil.

@haoel haoel merged commit 7eb4346 into megaease:main Jul 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants