Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable CGO to build static executable #141

Merged
merged 1 commit into from
Jun 15, 2022
Merged

disable CGO to build static executable #141

merged 1 commit into from
Jun 15, 2022

Conversation

hellojukay
Copy link
Contributor

No description provided.

@hellojukay
Copy link
Contributor Author

I find -ldflags '-s -w -extldflags "-static"' in Makefile , My guess is that you want to compile a static executable file。if no cgo dependencies in this project, i thank CGO should be disabled.

@codecov-commenter
Copy link

codecov-commenter commented Jun 15, 2022

Codecov Report

Merging #141 (1a83e33) into main (9d8abfa) will increase coverage by 0.16%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #141      +/-   ##
==========================================
+ Coverage   90.80%   90.97%   +0.16%     
==========================================
  Files          44       43       -1     
  Lines        2980     2968      -12     
==========================================
- Hits         2706     2700       -6     
+ Misses        203      199       -4     
+ Partials       71       69       -2     
Impacted Files Coverage Δ
daemon/daemon_windows.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d758e97...1a83e33. Read the comment docs.

Copy link
Contributor

@haoel haoel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR. Disable the CGO in the makefile is fine.

P.S. the EaseProbe release binaries are built by goreleaser(refer to the .goreleaser.yaml), which has already disabled the CGO

@haoel haoel merged commit 89cc8be into megaease:main Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants