Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add env and clean_env for shell notification and probe #136

Merged
merged 3 commits into from
Jun 9, 2022

Conversation

haoel
Copy link
Contributor

@haoel haoel commented Jun 9, 2022

if set the clean_env:true, the EaseProbe won't pass the OS environment variables to the shell notification and probe. the default value is false

@haoel haoel requested a review from proditis June 9, 2022 08:40
@codecov-commenter
Copy link

codecov-commenter commented Jun 9, 2022

Codecov Report

Merging #136 (4f6e19d) into main (6f566db) will decrease coverage by 0.13%.
The diff coverage is 83.49%.

@@            Coverage Diff             @@
##             main     #136      +/-   ##
==========================================
- Coverage   91.70%   91.57%   -0.14%     
==========================================
  Files          43       42       -1     
  Lines        2834     2908      +74     
==========================================
+ Hits         2599     2663      +64     
- Misses        168      176       +8     
- Partials       67       69       +2     
Impacted Files Coverage Δ
probe/common.go 100.00% <ø> (ø)
report/types.go 76.92% <ø> (ø)
probe/ssh/ssh.go 84.96% <66.66%> (ø)
report/result.go 90.62% <80.95%> (-2.24%) ⬇️
report/sla.go 92.81% <81.39%> (-1.63%) ⬇️
global/global.go 100.00% <100.00%> (ø)
probe/host/host.go 100.00% <100.00%> (ø)
probe/shell/shell.go 100.00% <100.00%> (ø)
daemon/daemon_windows.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1e3f7f...4f6e19d. Read the comment docs.

Copy link
Collaborator

@proditis proditis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and reviewed
LGTM

@haoel haoel merged commit 38e2d30 into megaease:main Jun 9, 2022
@haoel haoel deleted the shell branch June 24, 2022 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants