Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing keyframe parameter to videoroom configure #44

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

Qizot
Copy link
Contributor

@Qizot Qizot commented Jul 24, 2024

It happens that the configure function for videoroom plugin was missing the keyframe parameter that is supposed to request a keyframe for given publisher handle.

@Qizot
Copy link
Contributor Author

Qizot commented Jul 24, 2024

Just like with the last PR, can we bump the version and publish the package? Thanks!

@Qizot Qizot force-pushed the jp/videoroom-configure-keyframe branch from cbc9a41 to d9548d0 Compare July 24, 2024 12:30
@atoppi
Copy link
Member

atoppi commented Jul 24, 2024

Hi @Qizot thanks for the patch.
I'm afraid I can not tag a new version for every commit on the repo, it'd quickly become a mess!
May I ask why you need a release? What about pointing your package.json to the git repo on a specific commit?

@Qizot
Copy link
Contributor Author

Qizot commented Jul 24, 2024

@atoppi I guess we can point to the git repo, don't worry then.

@atoppi atoppi merged commit 84b41b8 into meetecho:master Jul 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants