Skip to content
This repository has been archived by the owner on Oct 30, 2022. It is now read-only.

Upgrade unmock and add unmock-jest-runner #36

Merged
merged 3 commits into from
Feb 14, 2020
Merged

Upgrade unmock and add unmock-jest-runner #36

merged 3 commits into from
Feb 14, 2020

Conversation

carolstran
Copy link
Contributor

@carolstran carolstran commented Feb 12, 2020

Bumped the unmock version to the latest 0.3.14 and added new unmock-jest-runner package.

@carolstran
Copy link
Contributor Author

carolstran commented Feb 12, 2020

There's an issue in some of the tests with the runner due to new unmock-runner package, will need to update to fix build.

@carolstran carolstran changed the title Upgrade unmock to v0.3.14 Upgrade unmock to v0.3.14 and add unmock-jest-runner Feb 13, 2020
@mikesol
Copy link

mikesol commented Feb 13, 2020

One recommendation would be to call the import runner instead of jestRunner. Otherwise LGTM!

@carolstran carolstran changed the title Upgrade unmock to v0.3.14 and add unmock-jest-runner Upgrade unmock and add unmock-jest-runner Feb 13, 2020
@carolstran carolstran merged commit ba50165 into master Feb 14, 2020
@carolstran carolstran deleted the bump-unmock branch February 14, 2020 23:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants