fix-3885 propagate traceId through asynchronous jobs
#3886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Ignored Deployments
|
|
@dillonstreator is attempting to deploy a commit to the Medplum Team on Vercel. A member of the Team first needs to authorize it. |
dillonstreator
changed the title
traceId through asynchronous jobstraceId through asynchronous jobs
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Good question. I think we need to add more documentation on tracing in general, so I'm ok to punt to future work.
Agree, I think cron is out of scope for trace ID, let's just ignore. Thanks @dillonstreator ! |
codyebberson
reviewed
Feb 8, 2024
There was a problem hiding this comment.
Thanks @dillonstreator - this all looks good to me. My focus was on the download and subscription workers, as those are quite critical to production workflows.
@mattwiller - can you double check the request ID and trace ID parts? They look good to me, but you're the expert on those.
mattwiller
approved these changes
Feb 8, 2024
medplumbot
added a commit
that referenced
this pull request
Feb 8, 2024
fix-3885 propagate `traceId` through asynchronous jobs (#3886) Expand profile operation (#3875) feat: Support OperationDefinition inputs for patient-everything (#3908) Remove TURBO_REMOTE_ONLY from build step (#3907) Server config setting for accurate count threshold (#3902) Remove global systemRepo (#3884) Maintain full `traceparent` header value for `traceId` (#3877) fix-3807 rectify fhirpath `exists` and `empty` (#3808) Fix return documentation for client read methods (#3891) Document how to switch to super admin project in projects (#3873) Refactor elements context and slicing logic (#3869) Dependency upgrades (#3874) No longer need to build core for @medplum/react npm run dev (#3871) Fixes to ResourceDiffTable with arrays (#3870) feat(agent): add `ping` via `Agent/$push` (#3846) Fix token search with pipe in value (#3867) Revert nested transactions (#3866) Evict connection on rollback (#3865)
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 8, 2024
fix-3885 propagate `traceId` through asynchronous jobs (#3886) Expand profile operation (#3875) feat: Support OperationDefinition inputs for patient-everything (#3908) Remove TURBO_REMOTE_ONLY from build step (#3907) Server config setting for accurate count threshold (#3902) Remove global systemRepo (#3884) Maintain full `traceparent` header value for `traceId` (#3877) fix-3807 rectify fhirpath `exists` and `empty` (#3808) Fix return documentation for client read methods (#3891) Document how to switch to super admin project in projects (#3873) Refactor elements context and slicing logic (#3869) Dependency upgrades (#3874) No longer need to build core for @medplum/react npm run dev (#3871) Fixes to ResourceDiffTable with arrays (#3870) feat(agent): add `ping` via `Agent/$push` (#3846) Fix token search with pipe in value (#3867) Revert nested transactions (#3866) Evict connection on rollback (#3865)
reshmakh
added
the
audit-logging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3885
This is based off of #3877 to include the work done to better support
traceparentand slight variations seen in the wild but it does not need to depend on it.Questions:
x-trace-id&traceparentheader? Could be a future documentation change consideration.