Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix-3809 race condition in Subscription extension fhir-path-criteria-expression %previous value lookup #3810

Merged
merged 2 commits into from
Jan 29, 2024
Merged

fix-3809 race condition in Subscription extension fhir-path-criteria-expression %previous value lookup #3810

merged 2 commits into from
Jan 29, 2024

Conversation

dillonstreator
Copy link
Contributor

Fixes #3809

@dillonstreator dillonstreator requested a review from a team as a code owner January 25, 2024 16:09
@vercel Vercel
Copy link

vercel bot commented Jan 25, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
medplum-app ⬜️ Ignored (Inspect) Visit Preview Jan 26, 2024 6:31pm
medplum-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 26, 2024 6:31pm
medplum-www ⬜️ Ignored (Inspect) Visit Preview Jan 26, 2024 6:31pm

@vercel Vercel
Copy link

vercel bot commented Jan 25, 2024

@dillonstreator is attempting to deploy a commit to the Medplum Team on Vercel.

A member of the Team first needs to authorize it.

mattwiller
mattwiller reviewed Jan 25, 2024
View reviewed changes
packages/server/src/workers/utils.ts
const evalInput = {
'%current': toTypedValue(currentResource),
'%previous': toTypedValue({}),
'%previous': toTypedValue(previous ?? {}),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious if something this might work better:

Suggested change
'%previous': toTypedValue(previous ?? {}),
'%previous': previous ? toTypedValue(previous) : undefined,

Copy link
Contributor Author

@dillonstreator dillonstreator Jan 25, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may want to address that change in #3808 as this PR purely addresses the race condition but FWIW, the variables typing as input to evalFhirPathTyped would not allow a value of undefined. It must be a TypedValue.

@codyebberson codyebberson added this pull request to the merge queue Jan 29, 2024
Merged via the queue into medplum:main with commit 9ec221f Jan 29, 2024
18 checks passed
@medplumbot medplumbot mentioned this pull request Jan 31, 2024
Merged
medplumbot added a commit that referenced this pull request Jan 31, 2024
@medplumbot
Release Version 3.0.2
f8d216d 
Fixes #3794 - MeasureReport.period search (#3850)
Extra check for vmcontext bots (#3863)
Add and use vite-plugin-turbosnap (#3849)
Downgrade chromatic (#3848)
Repo sql fixes for cockroachdb (#3844)
Remove Health Gorilla from medplum-demo-bots (#3845)
fix-3815 cache presigned s3 binary urls (#3834)
Use tsvector index for token text search (#3791)
rate limit should return `OperationOutcome` (#3843)
Add global var "module" to vm context bots (#3842)
Fix lookup table tsv indexes (#3841)
Always use estimate count first (#3840)
Disambiguate getClient (#3839)
Fix invalid mermaid graph in diagnostic catalog docs (#3836)
fix-3809 race condition in Subscription extension fhir-path-criteria-expression %previous value lookup (#3810)
Fix Sonar code smells: mark React props readonly (#3832)
RDS proxy (#3827)
Fixed lookup tables in migration generator (#3830)
Fixed deprecated jest matchers (#3831)
Update README.md (#3828)
Update fhir-basics.md (#3829)
Case study content and images (#3820)
Added rdsReaderInstanceType and RDS upgrade docs (#3826)
Dependency upgrades (#3825)
Separate search popup menus for 'text' and 'token' (#3824)
Improve performance of token sort (#3823)
Additional logging (#3790)
Fix calendar input button style (#3817)
Don't add _total default in SearchControl (#3818)
Dark mode (#3814)
Fixes #3812 - FHIR profile cache bug (#3813)
Document using medplum client to integrate with external FHIR servers (#3811)
Use specific advisory locks (#3805)
Nested transactions (#3788)
Fix signin page on graphiql (#3802)
fix(heartbeat): start heartbeat on first bind to sub (#3793)
Fix async job tests (#3795)
Document using vm context bots (#3784)
Refactored access policy docs based on customer feedback (#3785)
Support Redis TLS config from Env (#3787)
feat(subscriptions): add `heartbeat` for WS subs (#3740)
Update Bot metrics (#3763)
github-merge-queue bot pushed a commit that referenced this pull request Jan 31, 2024
@medplumbot
Release Version 3.0.2 (#3864)
d0b8f6e 
Fixes #3794 - MeasureReport.period search (#3850)
Extra check for vmcontext bots (#3863)
Add and use vite-plugin-turbosnap (#3849)
Downgrade chromatic (#3848)
Repo sql fixes for cockroachdb (#3844)
Remove Health Gorilla from medplum-demo-bots (#3845)
fix-3815 cache presigned s3 binary urls (#3834)
Use tsvector index for token text search (#3791)
rate limit should return `OperationOutcome` (#3843)
Add global var "module" to vm context bots (#3842)
Fix lookup table tsv indexes (#3841)
Always use estimate count first (#3840)
Disambiguate getClient (#3839)
Fix invalid mermaid graph in diagnostic catalog docs (#3836)
fix-3809 race condition in Subscription extension fhir-path-criteria-expression %previous value lookup (#3810)
Fix Sonar code smells: mark React props readonly (#3832)
RDS proxy (#3827)
Fixed lookup tables in migration generator (#3830)
Fixed deprecated jest matchers (#3831)
Update README.md (#3828)
Update fhir-basics.md (#3829)
Case study content and images (#3820)
Added rdsReaderInstanceType and RDS upgrade docs (#3826)
Dependency upgrades (#3825)
Separate search popup menus for 'text' and 'token' (#3824)
Improve performance of token sort (#3823)
Additional logging (#3790)
Fix calendar input button style (#3817)
Don't add _total default in SearchControl (#3818)
Dark mode (#3814)
Fixes #3812 - FHIR profile cache bug (#3813)
Document using medplum client to integrate with external FHIR servers (#3811)
Use specific advisory locks (#3805)
Nested transactions (#3788)
Fix signin page on graphiql (#3802)
fix(heartbeat): start heartbeat on first bind to sub (#3793)
Fix async job tests (#3795)
Document using vm context bots (#3784)
Refactored access policy docs based on customer feedback (#3785)
Support Redis TLS config from Env (#3787)
feat(subscriptions): add `heartbeat` for WS subs (#3740)
Update Bot metrics (#3763)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattwiller mattwiller mattwiller left review comments

@codyebberson codyebberson codyebberson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Medplum Product Roadmap
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Subscription extension fhir-path-criteria-expression race condition could cause unexpected %previous value
3 participants
@dillonstreator @codyebberson @mattwiller