feat(@medplum/core) Add AbortSignal support to client's createBinary and createAttachment methods
#3420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dillonstreator is attempting to deploy a commit to the Medplum Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Apply Sweep Rules to your PR?
|
There was a problem hiding this comment.
Thanks @dillonstreator - overall, this looks great to me, and this is a great feature.
See comment on using options: RequestInit for param type.
|
|
||
| // Ensure the 'abort' event listener is removed from the signal to prevent memory leaks, | ||
| // especially in scenarios where there is a long-lived signal across multiple requests. | ||
| const handleSignalAbort = (): void => xhr.abort(); |
codyebberson
approved these changes
Nov 30, 2023
Merged
medplumbot
added a commit
that referenced
this pull request
Dec 2, 2023
Fixes #3391 - setup git in preapare-release-yml (#3448) Create example bots that use a shared code library (#3441) Fixes #2789 - support 'delete' subscriptions with bots (#3426) (#3445) Fixes #3391 - github action for prepare-release.sh (#3443) Revert "Fixes #2789 - support 'delete' subscriptions with bots (#3426)" (#3444) Update AWS instructions (#3437) Bump @adobe/css-tools from 4.3.1 to 4.3.2 (#3440) Fix ValidBot warnings (#3438) Fixes #3404 - add Referrer-Policy and Permissions-Policy headers (#3436) Fixes #2789 - support 'delete' subscriptions with bots (#3426) Agent source cleanup (#3431) Stop reviving removed meta properties (#3432) Create docs for building questionnaires (#3393) feat(@medplum/core) Add `AbortSignal` support to client's `createBinary` and `createAttachment` methods (#3420) Fixes #3401 - Handle no AWS credentials in AWS init tool (#3418) Revert "`BinarySource` supporting `ReadableStream` (#3411)" (#3421) Add bulleted list of SuperAdmin priveleges (#3408) Add a note that config must be updated locally when making changes (#3410) Improve linking for using binary data (#3406) Fixes #3413 - set meta.author when updating access policy (#3419) `BinarySource` supporting `ReadableStream` (#3411) Handle non-string code in formatCoding (#3415) Fixes #3414 - use ESM in example apps (#3416) Fixes #3389 - add vercel.json config to examples (#3417) feat(fhircast): add `heartbeat` event (#3350) Add note about graphql respecting access policies (#3403) Fixes #3395 - Build scripts handle no git repo (#3400) Dependency upgrades (#3397) Add callout for batch vs transaction bundles (#3399) Fixes #3395 - Build scripts handle no git repo (#3396) Improve examples in the include search docs (#3359) QuestionnaireBuilder Autosave (#3253) chore(package.json): add `private: true` to root (#3390) Docs: FHIR Profile Creation & Search (#3357)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 2, 2023
Fixes #3391 - setup git in preapare-release-yml (#3448) Create example bots that use a shared code library (#3441) Fixes #2789 - support 'delete' subscriptions with bots (#3426) (#3445) Fixes #3391 - github action for prepare-release.sh (#3443) Revert "Fixes #2789 - support 'delete' subscriptions with bots (#3426)" (#3444) Update AWS instructions (#3437) Bump @adobe/css-tools from 4.3.1 to 4.3.2 (#3440) Fix ValidBot warnings (#3438) Fixes #3404 - add Referrer-Policy and Permissions-Policy headers (#3436) Fixes #2789 - support 'delete' subscriptions with bots (#3426) Agent source cleanup (#3431) Stop reviving removed meta properties (#3432) Create docs for building questionnaires (#3393) feat(@medplum/core) Add `AbortSignal` support to client's `createBinary` and `createAttachment` methods (#3420) Fixes #3401 - Handle no AWS credentials in AWS init tool (#3418) Revert "`BinarySource` supporting `ReadableStream` (#3411)" (#3421) Add bulleted list of SuperAdmin priveleges (#3408) Add a note that config must be updated locally when making changes (#3410) Improve linking for using binary data (#3406) Fixes #3413 - set meta.author when updating access policy (#3419) `BinarySource` supporting `ReadableStream` (#3411) Handle non-string code in formatCoding (#3415) Fixes #3414 - use ESM in example apps (#3416) Fixes #3389 - add vercel.json config to examples (#3417) feat(fhircast): add `heartbeat` event (#3350) Add note about graphql respecting access policies (#3403) Fixes #3395 - Build scripts handle no git repo (#3400) Dependency upgrades (#3397) Add callout for batch vs transaction bundles (#3399) Fixes #3395 - Build scripts handle no git repo (#3396) Improve examples in the include search docs (#3359) QuestionnaireBuilder Autosave (#3253) chore(package.json): add `private: true` to root (#3390) Docs: FHIR Profile Creation & Search (#3357)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
AbortSignalsupport tocreateBinaryandcreateAttachmentby exposing an optionalsignal: AbortSignalthat is propagated to the clients fetch interface as well as theXMLHttpRequest