improve some doc cohesion and fix generator->definitions README link #3373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Ignored Deployments
|
|
@dillonstreator is attempting to deploy a commit to the Medplum Team on Vercel. A member of the Team first needs to authorize it. |
Apply Sweep Rules to your PR?
|
dillonstreator
commented
Nov 24, 2023
| @@ -23,7 +23,7 @@ When considering which option is best for you, we must consider some system char | |||
| - How easy or difficult is it to modify the existing system? | |||
| - Are engineers actively updating the existing system? | |||
| - How frequently does the existing system deploy new releases? | |||
| - Is the existing system stable, or are changes avoided? | |||
| - Is the existing system stable, or is change frequent? | |||
There was a problem hiding this comment.
I'm not entirely confident that this change accurately captures the original intention, but it seems the intention was to convey opposites. In my view, a "stable system" typically implies avoiding changes.
I suppose this is context-dependent; for instance, when discussing the stability of an API, frequent change may suggest lower stability. On the other hand, in the context of internal component modifications, updates could potentially enhance stability.
codyebberson
approved these changes
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.