fix request logging middleware status code reporting #3316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
|
Someone is attempting to deploy a commit to the Medplum Team on Vercel. A member of the Team first needs to authorize it. |
Apply Sweep Rules to your PR?
|
mattwiller
approved these changes
Nov 14, 2023
|
Thanks @dillonstreator! ✨ |
codyebberson
added a commit
that referenced
this pull request
Nov 14, 2023
Fixes #3269 - use shawl for agent service admin (#3314) fix request logging middleware status code reporting (#3316) Docusaurus 3 (#3311) Redirect to next from signin page if already authenticated (#3294) Ensure trailing slash on external auth signin page (#3306) Fix Admin Users doc page title (#3299) Document setting up Google auth for Medplum App (#3302) Update domain level idp docs (#3298) Added separate scripts for 'build' and 'build:all' (#3303) Dependency upgrades (#3285) Make @medplum/core a module (#3263) feat(client/fhircast): add `fhircastGetContext` (#3292) Add some margin to ResourceArrayInput and make it flex-based (#3295) Don't show copy button for ID if empty/missing (#3297) Add link to Tasks guide for charting demo README (#3288) Show language and text when nested (#3296) Fixed projects guide link (#3281) Fix highlighting of default tab (#3293) Remove option for 1 AZ in AWS setup (#3283)
Merged
codyebberson
added a commit
that referenced
this pull request
Nov 14, 2023
Fixes #3269 - use shawl for agent service admin (#3314) fix request logging middleware status code reporting (#3316) Docusaurus 3 (#3311) Redirect to next from signin page if already authenticated (#3294) Ensure trailing slash on external auth signin page (#3306) Fix Admin Users doc page title (#3299) Document setting up Google auth for Medplum App (#3302) Update domain level idp docs (#3298) Added separate scripts for 'build' and 'build:all' (#3303) Dependency upgrades (#3285) Make @medplum/core a module (#3263) feat(client/fhircast): add `fhircastGetContext` (#3292) Add some margin to ResourceArrayInput and make it flex-based (#3295) Don't show copy button for ID if empty/missing (#3297) Add link to Tasks guide for charting demo README (#3288) Show language and text when nested (#3296) Fixed projects guide link (#3281) Fix highlighting of default tab (#3293) Remove option for 1 AZ in AWS setup (#3283)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the
logRequestsconfig enabled, the request logging middleware reports 200 status code regardless of non-200 status codes being sent to the client.res.on('finish', () => {})should be used to properly hook into response being sent and report the actual status code.❗ Note this PR also changes the log property
requestMethod->method. @mattwiller called this out in his comment #3196 (comment) on the PR introducing this logging middleware. At this point, it would technically be considered a breaking change so I'd understand if this is not desired and is preferred to be kept asrequestMethod.