Move "public" resources into R4 Project #2591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
mattwiller
added
the
fhir-datastore
jamestouri
approved these changes
Aug 21, 2023
|
Discussed - test in staging. @mattwiller @codyebberson |
codyebberson
approved these changes
Sep 6, 2023
| @@ -113,12 +113,14 @@ function getResourceTypesByExportLevel(exportLevel: string): ResourceType[] { | |||
| return getResourceTypes(); | |||
| } | |||
|
|
|||
| const unexportedResourceTypes = ['CodeSystem', 'SearchParameter', 'StructureDefinition', 'ValueSet']; | |||
|
|
|||
| function canBeExported(resourceType: string): boolean { | |||
| if (resourceType === 'BulkDataExport') { | |||
There was a problem hiding this comment.
Now that we're introducing unexportedResourceTypes, should we move the BulkDataExport into that?
Then this method becomes return !protectedResourcesTypes.includes(resourceType) && !unexportedResourceTypes.includes(resourceType)
| const updateQuery = `UPDATE "__TABLE__" SET | ||
| "projectId" = $1::UUID, | ||
| compartments = ARRAY[$1]::UUID[], | ||
| content = jsonb_set(content::jsonb, '{meta, project}'::text[], to_jsonb($1), true) |
|
Staging deploy failed:
Does the migration handle the case where the resource is deleted, and the |
| compartments = ARRAY[$1]::UUID[], | ||
| content = jsonb_set(content::jsonb, '{meta, project}'::text[], to_jsonb($1), true) | ||
| WHERE | ||
| "projectId" IS NULL OR "projectId" = $1`; |
There was a problem hiding this comment.
Might need to add AND "content"<>''
|
Kudos, SonarCloud Quality Gate passed! |
codyebberson
approved these changes
Sep 12, 2023
codyebberson
added a commit
that referenced
this pull request
Sep 13, 2023
Use data migrations in version numbers (#2816) Fixes #2784 - Data migrations framework (#2786) Fixes #2817 - add jose to bot lambda layer (#2818) Move "public" resources into R4 Project (#2591) fix(auth/external): add some missing url params for external auth `PKCE` exchanges (#2812) Experiment: remove prettier from ESLint config, try out Biome (Rome fork) (#2748) Fixes #2808 - handle observation groups in DiagnosticReportDisplay (#2809) Adding content for Titan case study (#2806) QuestionnaireForm Cleanup (#2801) UI Clone for Lab Order Questionnaire (#2787) Lab order bot (#2791) Blog Post: GraphQL vs. Rest (#2781) Fixes #2761 - docs for bot logs and aws athena (#2779) Adding EMPI documentation (#2754) Example on Lab Ordering demo (#2716) Fixed links on about page (#2777) Adding blog material (#2776) Fixes #2771 - handle numeric return values from bots (#2775) New www 'about' page (#2770)
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 13, 2023
Use data migrations in version numbers (#2816) Fixes #2784 - Data migrations framework (#2786) Fixes #2817 - add jose to bot lambda layer (#2818) Move "public" resources into R4 Project (#2591) fix(auth/external): add some missing url params for external auth `PKCE` exchanges (#2812) Experiment: remove prettier from ESLint config, try out Biome (Rome fork) (#2748) Fixes #2808 - handle observation groups in DiagnosticReportDisplay (#2809) Adding content for Titan case study (#2806) QuestionnaireForm Cleanup (#2801) UI Clone for Lab Order Questionnaire (#2787) Lab order bot (#2791) Blog Post: GraphQL vs. Rest (#2781) Fixes #2761 - docs for bot logs and aws athena (#2779) Adding EMPI documentation (#2754) Example on Lab Ordering demo (#2716) Fixed links on about page (#2777) Adding blog material (#2776) Fixes #2771 - handle numeric return values from bots (#2775) New www 'about' page (#2770)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates a special Project for holding the base R4 FHIR specification conformance resources. The goal is to allow inclusion of those resources into other projects effectively via reference, so the hundreds of
StructureDefinitionand other resources do not live in each Project separately. This change includes:Repositoryto add the R4Projectcompartment to all DB read queries; blocking all writes across project boundariesRelated to #2581