Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support terminologies in ValueSet expand operation #1213

Merged
merged 6 commits into from
Dec 10, 2022
Merged

Support terminologies in ValueSet expand operation #1213

merged 6 commits into from
Dec 10, 2022

Conversation

codyebberson
Copy link
Member

@codyebberson codyebberson commented Dec 4, 2022 •
edited
Loading

Before:

  • We did not actually create ValueSet and CodeSystem resources
  • We precomputed everything for the ValueSet/$expand operation
  • It was not possible to use the $expand operation for custom resources
  • It was not possible to follow a ValueSet.url to an external terminology such as SNOMED, LOINC, etc

After:

  • We create ValueSet and CodeSystem resources
  • We evaluate the mapping of ValueSet to system (s) at runtime
  • We re-index ValueSet and CodeSystem resources codes, using the same pattern as Address, ContactPoint, HumanName, etc
  • This enables $expand for custom resources
  • This enables $expand for external terminologies

@codyebberson codyebberson requested a review from a team as a code owner December 4, 2022 19:33
@vercel
Copy link

vercel bot commented Dec 4, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Updated
medplum-storybook ⬜️ Ignored (Inspect) Dec 10, 2022 at 9:25PM (UTC)
medplum-www ⬜️ Ignored (Inspect) Dec 10, 2022 at 9:25PM (UTC)

@codyebberson
Copy link
Member Author

Big step toward #992

@coveralls
Copy link

coveralls commented Dec 4, 2022 •
edited
Loading

Coverage Status

Coverage decreased (-0.008%) to 94.078% when pulling b913b30 on cody-valueset-expand-runtime into 470aa01 on main.

@reshmakh reshmakh added the fhir-datastore Related to the FHIR datastore, includes API and FHIR operations label Dec 6, 2022
@reshmakh reshmakh added the medications Features and fixes related to medications label Dec 10, 2022
@sonarcloud
Copy link

sonarcloud bot commented Dec 10, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

95.0% 95.0% Coverage
0.0% 0.0% Duplication

@codyebberson codyebberson merged commit 338efd6 into main Dec 10, 2022
@codyebberson codyebberson deleted the cody-valueset-expand-runtime branch December 10, 2022 22:24
@reshmakh reshmakh mentioned this pull request Dec 11, 2022
Closed
@codyebberson codyebberson mentioned this pull request Dec 17, 2022
Merged
@tonylee80 tonylee80 mentioned this pull request Apr 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reshmakh reshmakh reshmakh approved these changes

Assignees
No one assigned
Labels
fhir-datastore Related to the FHIR datastore, includes API and FHIR operations medications Features and fixes related to medications
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@codyebberson @coveralls @reshmakh