Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search for multiple types without base resource is not possible #4186

Closed
skomski opened this issue Mar 18, 2024 · 3 comments · Fixed by #4199
Closed

Search for multiple types without base resource is not possible #4186

skomski opened this issue Mar 18, 2024 · 3 comments · Fixed by #4199

Comments

@skomski
Copy link

skomski commented Mar 18, 2024

I think this should be possible GET [base]/?_type=Task,CarePlan but currently leads to the OperationOutcome Unknown resource type. This is possible GET [base]/Task?_type=Task,CarePlan but rather weird.

https://www.hl7.org/fhir/R4/search.html#_type
@codyebberson
Copy link
Member

Eek, yep, thanks @skomski

codyebberson added a commit that referenced this issue Mar 19, 2024
@codyebberson
Fixes #4186 - resource type validation for search with _type
f7fe24e
github-merge-queue bot pushed a commit that referenced this issue Mar 19, 2024
@codyebberson
Fixes #4186 - resource type validation for search with _type (#4192)
910e60c 
* Fixes #4186 - resource type validation for search with _type

* Add test for trailing slash
@ThatOneBro
Copy link
Member

Closed as completed via #4192

medplumbot added a commit that referenced this issue Mar 19, 2024
@medplumbot
Release Version 3.0.11
3014172 
Fixes #4140 - Add WWW-Authenticate header to unauthorized response (#4167)
feat(getwsbindingtoken): add feature gate on `websocket-subscriptions` (#4193)
Fixes #4186 - resource type validation for search with _type (#4192)
Update hl7-into-fhir.md (#4191)
Handle additional terminology operation endpoints (#4188)
Dependency upgrades (#4179)
Implement Binary.securityContext check (#4182)
Adding External IDP Demo (#4099)
Update documentation on messaging (#4135)
feat(react): add `BaseChat` and `ThreadChat` components (#4111)
Document the medplum app sign in page (#4083)
@medplumbot medplumbot mentioned this issue Mar 19, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Mar 20, 2024
@medplumbot
Release Version 3.0.11 (#4199)
5d91a34 
Fixes #4140 - Add WWW-Authenticate header to unauthorized response (#4167)
feat(getwsbindingtoken): add feature gate on `websocket-subscriptions` (#4193)
Fixes #4186 - resource type validation for search with _type (#4192)
Update hl7-into-fhir.md (#4191)
Handle additional terminology operation endpoints (#4188)
Dependency upgrades (#4179)
Implement Binary.securityContext check (#4182)
Adding External IDP Demo (#4099)
Update documentation on messaging (#4135)
feat(react): add `BaseChat` and `ThreadChat` components (#4111)
Document the medplum app sign in page (#4083)
@tlater-famedly
Copy link

tlater-famedly commented Apr 8, 2024 •
edited
Loading

To be clear, AIUI the spec still lists being able to search across all resources with arbitrary additional criteria:

  • Using search across all resource types (GET [base]?params...)

But medplum is deliberately noncompliant here for performance, so searches must be made with _type set to something:

To maintain performance, FHIR doesn't allow Resources to be queried by arbitrary elements. Instead, it defines a set of search parameters for each Resource Type.

Is that correct?

Yep, sorry for the noise: #4355

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Medplum Product Roadmap
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Release Version 3.0.11 medplum/medplum
4 participants
@skomski @codyebberson @ThatOneBro @tlater-famedly