Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed URLSearchParams constructor call #9

Merged
merged 1 commit into from
Jul 25, 2022
Merged

Conversation

codyebberson
Copy link
Member

@codyebberson codyebberson commented Jul 25, 2022

TypeScript definition for URLSearchParams constructor:

var URLSearchParams: new (init?: string | URLSearchParams | Record<string, string | readonly string[]> | Iterable<[string, string]> | readonly [string, string][] | undefined) => URLSearchParams

Before, we used the Record<string, string[]> variant, but apparently that is not widely available.

Now, we use the readonly [string, string][] variant, which appears to be ubiquitous.

https://developer.mozilla.org/en-US/docs/Web/API/URLSearchParams/URLSearchParams

@reshmakh reshmakh merged commit 5a2a6a1 into main Jul 25, 2022
@reshmakh reshmakh deleted the cody-urlsearchparams-ctor branch July 25, 2022 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants