Opkit bot changes #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I went ahead and added the dummy subscriber! Here is the updated opkit-bot code with some of the changes necessary to make it work :). The dummy subscriber and payer are live on our backend. If you replace the
<opkit-public-api-key>and run the test, this should pass.I also attempted to deploy this as a bot on the Opkit medplum app, but ran into issues importing modules and using buffers. I think this may be because of the sandboxed bot environment. Is there anything we can do here?
We also saw that there were no implicit any's in the codebase. I would love to be able to use the OAS generated SDK (comes with our typings so we don't have to use
any), but I held off on making that change until I figured out what tools are available in the sandboxed environment first. LMK what you think!