fix(#9065): block offline users from using api/v1/person endpoint #9205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkuester
commented
Jun 24, 2024
| @@ -17,7 +16,7 @@ export namespace v1 { | |||
| return false; | |||
| } | |||
| const hasPersonType = contactTypeUtils.isPerson(settings.getAll(), doc); | |||
| if (!hasPersonType || !isNormalizedParent(doc)) { | |||
There was a problem hiding this comment.
Decided to go ahead and drop this extra isNormalizedParent logic here before this gets released in 4.9 (as originally intended in https://github.com/medic/cht-core/pull/9177/files#r1644945012).
|
@m5r can you please merge this one you are happy with how it looks? 🙏 CC @latin-panda |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Result of #9065 (comment)
Closes #9065
Basically this PR just adds a check to the REST api so that only online users (user with full DB access) can call the
personendpoint.Code review checklist
Compose URLs
If Build CI hasn't passed, these may 404:
License
The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.