fix: update lmp calculation to fix flaky test #9170
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The test
/tests/e2e/default/contacts/contact-details.wdio-spec.js
started being flaky on the CI as noted by #9155.The initlal lmp calculation was
const lmp = moment().subtract(3, 'months');
My initial hypothesis and investigation suggested the
lmp
value was varying depending on the date the test is run and how many days the previous 3 months had.Therefore, the fix I came up with was to use a fixed date and then subtract a specific number of days so that lmp will always be 12 weeks.
Unfortunately, the test is still flaky.
const lmp = moment().subtract(3, 'months');
fails by giving 13 weeks instead of the expected 12 weeksIf you run any of the two above in master, the test fails.
The change made in this PR hopefully stabilises the test but @lorerod I welcome your thought on this
Code review checklist
Compose URLs
If Build CI hasn't passed, these may 404:
License
The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.