chore(#9080): adds logger shared lib

[dianabarsan]

Description

#9080

Code review checklist

• Readable: Concise, well named, follows the style guide, documented if necessary.
• Documented: Configuration and user documentation on cht-docs
• Tested: Unit and/or e2e where appropriate
• Internationalised: All user facing text
• Backwards compatible: Works with existing data and configuration or includes a migration. Any breaking changes documented in the release notes.

Compose URLs

If Build CI hasn't passed, these may 404:

• Core
• CouchDB Single
• CouchDB Cluster

License

The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.

[dianabarsan]

Can I please have your thoughts @garethbowen ? Thanks!!

[garethbowen]

One refactor suggestion, but otherwise this is great!

[garethbowen]

❤️

[garethbowen]

Woohoo! Death to rewire!

[dianabarsan]

yes! i concur!

[garethbowen]

@dianabarsan One more random thought... in node services we often log like log.error("got error: %o", err) - but that won't work in the browser, right? Do we have to just be careful to not use that format in shared-libs?

[dianabarsan]

in node services we often log like log.error("got error: %o", err)

Correct, this kind of formatting won't work in the browser. Nothing is going to break, but we won't achieve the desired result. I suppose we can continue to use this format when we know the code will only be used in nodejs - in libraries like server-checks for example.

[garethbowen]

@dianabarsan What about this: https://www.npmjs.com/package/winston-transport-browserconsole ? It might mean the logging API is consistent between node and browser?

[dianabarsan]

@dianabarsan What about this: https://www.npmjs.com/package/winston-transport-browserconsole ? It might mean the logging API is consistent between node and browser?

I've read about it. People said it bulks the browser bundle. I'll try it out though.

[dianabarsan]

It looks like winston-transport-browserconsole it doesn't work out of the box:

It looks like setImmediate has been deprecated for a while: https://developer.mozilla.org/en-US/docs/Web/API/Window/setImmediate and the library hasn't received any update in years. I'm reluctant to use it.

Do you think it's worth more time working out how to generalize logging in webapp in this PR?

[garethbowen]

Awesome, thanks!