Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(#8982): upgrade to angular 17 #8983

Merged
merged 6 commits into from
Apr 22, 2024
Merged

chore(#8982): upgrade to angular 17 #8983

merged 6 commits into from
Apr 22, 2024

Conversation

garethbowen
Copy link
Member

@garethbowen garethbowen commented Apr 2, 2024

Description

#8982

Code review checklist

  • Readable: Concise, well named, follows the style guide, documented if necessary.
  • Documented: Configuration and user documentation on cht-docs
  • Tested: Unit and/or e2e where appropriate
  • Internationalised: All user facing text
  • Backwards compatible: Works with existing data and configuration or includes a migration. Any breaking changes documented in the release notes.

Compose URLs

If Build CI hasn't passed, these may 404:

License

The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.

@garethbowen garethbowen marked this pull request as draft April 2, 2024 11:42
@garethbowen
Copy link
Member Author

Needs to be tested on Chrome 90 - blocked on #8963

@garethbowen garethbowen marked this pull request as ready for review April 19, 2024 10:46
@garethbowen
Copy link
Member Author

@latin-panda Can I get a review please? Mostly it was straightforward the zone unhandled rejection change was a pain!

If it's not too much trouble it would be fascinating to see if this impacts UX performance at all...

@latin-panda
Copy link
Contributor

latin-panda commented Apr 19, 2024

@garethbowen Happy to review this, but I'll be unavailable until Wednesday. I suggest asking review from another developer to not block this upgrade

@garethbowen
Copy link
Member Author

Ok. Thanks! @Benmuiruri you're up!

@garethbowen garethbowen requested review from Benmuiruri and removed request for latin-panda April 19, 2024 11:43
Copy link
Contributor

@Benmuiruri Benmuiruri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I'm not sure what sort of UI performance testing you had in mind. But I decided to take Angular Plugin for a spin. The results kept changing ever so slightly between 16 and 17 here is an example of one of the runs.

I basically clicked through the Tabs and navigated around in the same path for both 16 and 17.

Time spent on Angular 17

messages 21ms
task component 51.5 ms 
App component 76.8 ms
reports 40 ms 
contacts content 34 ms
contacts content 170 ms 
contacts content 74 ms
contacts content 193 ms 

Time spent on Angular 16

messages 13ms 
tasks 40ms
app 66.8 ms
Reports 41.6ms 
contacts content 30ms
contacts content 158 ms 
contacts content 68.8 ms 
contacts content 188.6 ms 


@garethbowen garethbowen merged commit 0338b02 into master Apr 22, 2024
34 checks passed
@garethbowen garethbowen deleted the angular-17 branch April 22, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants