Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#8939): display of Eketo's or-appearance-list-nolabel #8972

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

latin-panda
Copy link
Contributor

@latin-panda latin-panda commented Mar 26, 2024

Description

  • Excludes or-appearance-list-nolabel from the style that displays options.
Test video:
enketo-min.mp4
Screenshots mobile Screenshot 2024-03-26 at 5 20 17 PM Screenshot 2024-03-26 at 5 12 07 PM Screenshot 2024-03-26 at 5 21 23 PM Screenshot 2024-03-26 at 5 22 28 PM Screenshot 2024-03-26 at 5 22 21 PM Screenshot 2024-03-26 at 5 22 12 PM Screenshot 2024-03-26 at 5 22 01 PM Screenshot 2024-03-26 at 5 21 53 PM Screenshot 2024-03-26 at 5 21 40 PM

#8939

Code review checklist

  • Readable: Concise, well named, follows the style guide, documented if necessary.
  • Documented: Configuration and user documentation on cht-docs
  • Tested: Unit and/or e2e where appropriate
  • Internationalised: All user facing text
  • Backwards compatible: Works with existing data and configuration or includes a migration. Any breaking changes documented in the release notes.

Compose URLs

If Build CI hasn't passed, these may 404:

License

The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.

@latin-panda
Copy link
Contributor Author

@jkuester @ralfudx This fix is tiny, but most of the job here is testing the options in each question is okay, I have included screenshots and a video in the PR's description box

@latin-panda latin-panda linked an issue Mar 26, 2024 that may be closed by this pull request
Copy link
Contributor

@jkuester jkuester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I have done a side-by-side comparison of this change with the following forms from support-scripts and did not see any differences! LGMT

  • enketo_widgets
  • base64-image
  • child-from-repeat-group
  • countdown-timer
  • date-input
  • dynamic-url
  • external-data
  • format-date
  • jr-choice-name
  • multiple-repeats
  • no-choice-name
  • non-relevant-first-page
  • output-initial
  • multimedia
  • multimedia-repeats

@latin-panda
Copy link
Contributor Author

Hi @ralfudx is it okay if I merge?

@latin-panda latin-panda merged commit cc9d200 into master Apr 2, 2024
30 checks passed
@latin-panda latin-panda deleted the 8939-grid-display-in-forms-broken branch April 2, 2024 06:25
@latin-panda
Copy link
Contributor Author

@ralfudx Since you won't be able to review this in a while, I went ahead and merged it to keep things going; Josh and I tested the feature well, and it's been documented in this PR. If you have any additional feedback, I can open a new PR to address it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Select question grid display in forms broken
2 participants