Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#8877): Look up users from their facility_id or contact_id #8928

Merged
merged 66 commits into from
Apr 18, 2024

Conversation

m5r
Copy link
Member

@m5r m5r commented Mar 13, 2024

Description

Issue: #8877
Docs PR: medic/cht-docs#1318

This extends the GET /api/v2/users route to support passing a facility_id and/or a contact_id in query parameters and get back a list of users who matched. It's gated behind the same can_view_users permission.

Code review checklist

  • Readable: Concise, well named, follows the style guide, documented if necessary.
  • Documented: Configuration and user documentation on cht-docs
  • Tested: Unit and/or e2e where appropriate
  • Internationalised: All user facing text
  • Backwards compatible: Works with existing data and configuration or includes a migration. Any breaking changes documented in the release notes.

Compose URLs

If Build CI hasn't passed, these may 404:

License

The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.

api/src/controllers/users.js Outdated Show resolved Hide resolved
@m5r m5r marked this pull request as ready for review March 21, 2024 07:24
@m5r m5r changed the title feat(#8877): Support ability to look up a single user feat(#8877): Look up users from their facility_id or contact_id Mar 21, 2024
@m5r
Copy link
Member Author

m5r commented Mar 21, 2024

@kennsippell could you give it a look and see if this would help with the user management needs raised in #8877 ?

You also mentioned wanting a route to lookup a single user by username. It is not included it in this PR but there is a WIP incremental PR #8959 we could ship next if that's valuable for user management

@m5r m5r requested a review from jkuester March 21, 2024 08:22
Copy link
Contributor

@jkuester jkuester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is complete from my perspective! Before merging, it would be good to get some feedback on the following:

@dianabarsan can you have a quick look, when you get the chance, at the new migration and the new views for the _users db? I just want to be sure that is what you expected! (And we do not add migrations/views all the time so just want to double-check my work here... 🤞 ).

@m5r can you have a look at the revisions I made? The biggest change was switching from the _find Mango query to normal Couch views. I ended up doing this for these reasons:

  1. Performance for the un-indexed Mango query was 14x worse than with the views with 10000 users. The performance of the Mango query was not abysmal, but it seemed like we did not have much of a reason to take the performance hit. (FTR, I did look into indexing the Mango query. That provided equivalent performance as the view, but we do not currently have a pattern of creating/maintaining Mango indexes like we do views, so more work is needed before we can deploy them).
  2. As far as I can tell, we do not actually use the Mango find call anywhere in our code right now except for the DB migrations (where custom views do not make sense). This made me reluctant to introduce the pattern here (unless this is a direction we intentionally want to move...)
  3. I guess the pouchdb-find dependency is required to use that functionality and not all the consumers of user-management are currently importing that dependency (e.g. sentinel). This is not a huge deal since sentinel could always pull in that package if we ever start to hit this code flow, but it added to my unease.
  4. I found that the Mango find has a default 25 doc limit on what it returns. We can set a higher limit, but there does not seem to be a way to go unlimited. Whenever we do use find we should be sure to implement paging logic so we get all the results... (Actually logged an issue because neither of the other places where we are using Pouch.find are actually accounting for this limit either... 🤦 )

Copy link
Member

@dianabarsan dianabarsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work here! Looking really good.
I left a few small requests inline.

api/src/controllers/users.js Outdated Show resolved Hide resolved
shared-libs/user-management/src/users.js Outdated Show resolved Hide resolved
shared-libs/user-management/src/users.js Outdated Show resolved Hide resolved
shared-libs/user-management/src/users.js Outdated Show resolved Hide resolved
api/tests/integration/migrations/add-contact-id-to-user.js Outdated Show resolved Hide resolved
api/tests/integration/migrations/utils.js Show resolved Hide resolved
ddocs/users-db/users/views/users_by_contact_id/map.js Outdated Show resolved Hide resolved
shared-libs/user-management/src/users.js Show resolved Hide resolved
Copy link
Member

@dianabarsan dianabarsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work! Not only is this a nice feature, we're also pushing for consistency and security of data by having the contact_id stored in the user doc. Love it!

@m5r m5r merged commit 5e9032d into master Apr 18, 2024
32 checks passed
@m5r m5r deleted the 8877-lookup-single-user branch April 18, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

/api/v2/users look up users by facility_id and/or contact_id
5 participants