fix(#8789): targets aggregates test is failing silently #8834
Conversation
| validateCardField('Last updated', 'yesterday Clarissa'); | ||
| validateCardField('what a target!', '40'); | ||
| validateCardField('the most target', '50%'); |
There was a problem hiding this comment.
The reason the tests were failing silently is these validations weren't being awaited. As soon as I added the await the test failed.
| @@ -363,11 +363,17 @@ const exportContacts = async () => { | |||
| await (await exportButton()).click(); | |||
| }; | |||
|
|
|||
| const getCardFieldInfo = async (label) => { | |||
| return { | |||
| label: await (await $(`.cell.${label} label`)).getText(), | |||
There was a problem hiding this comment.
This never worked. We didn't have a class for the label, and even if we did, we we using spaces in the label which would have broken this CSS selector completely.
There was a problem hiding this comment.
Hi @garethbowen, thanks for fixing the e2e test. I left a suggestion, but it's not a blocker.
| expect(card.label).to.equal(label); | ||
| expect(card.value).to.equal(value); | ||
| const validateCardFields = async (lastUpdated, firstTarget, secondTarget) => { | ||
| const fields = await contactsPage.getContactSummaryCardFields(); |
There was a problem hiding this comment.
Is it possible to use text selectors for contact summary card fields?
And, validate the text directly instead of first getting the fields and then validating the text. Something similar to what @tatilepizs has done in common-enketo page objects.
There was a problem hiding this comment.
Oooh yes I like this. Initially I tried to keep the API as close as possible to the original, but seeing as it's only used in this one place I think I can change it to do whatever I like. Thanks for the prompt!
Description
#8789
Code review checklist
Compose URLs
If Build CI hasn't passed, these may 404:
License
The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.