Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(#8701): Clean and organize e2e tests: folder /enketo #8812

Merged
merged 48 commits into from
Feb 15, 2024
Merged

chore(#8701): Clean and organize e2e tests: folder /enketo #8812

merged 48 commits into from
Feb 15, 2024

Conversation

tatilepizs
Copy link
Contributor

@tatilepizs tatilepizs commented Jan 16, 2024 •
edited
Loading

Description

Clean and organize the e2e tests that are inside the enketo folder.

  • add-family.wdio-spec.js
  • db-object-widget.wdio-spec.js
  • death-report.wdio-spec.js
  • edit-report-with-attachment.wdio-spec.js
  • enketo-widgets.wdio-spec.js
  • extension-lib-form.wdio-spec.js
  • pregnancy-complete-a-delivery.wdio-spec.js
  • pregnancy-danger-sign-follow-up.wdio-spec.js
  • pregnancy-facility-visit-reminder.wdio-spec.js
  • pregnancy-visit.wdio-spec.js
  • pregnancy.wdio-spec.js
  • repeat.wdio-spec.js
  • submit-countdown-timer-form.wdio-spec.js
  • submit-default-delivery-form.wdio-spec.js
  • submit-form.wdio-spec.js
  • submit-photo-upload-form.wdio-spec.js
  • submit-z-score-form.wdio-spec.js
  • training-cards.wdio-spec.js
  • unauthorized-form.wdio-spec.js
  • undo-death-report.wdio-spec.js

#8701

Code review checklist

  • Readable: Concise, well named, follows the style guide, documented if necessary.
  • Documented: Configuration and user documentation on cht-docs
  • Tested: Unit and/or e2e where appropriate
  • Internationalised: All user facing text
  • Backwards compatible: Works with existing data and configuration or includes a migration. Any breaking changes documented in the release notes.

Compose URLs

If Build CI hasn't passed, these may 404:

License

The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.

@tatilepizs
Clean and organize add-family e2e test
c64dfe4
@tatilepizs
Clean and organize db-object-widget e2e test
243ebc3
@tatilepizs
Merge branch 'master' of https://github.com/medic/cht-core into 8701-…
967b53e 
…clean-and-organize-enketo-folder
@tatilepizs
clean death and test
3653a44
@tatilepizs
Remove duplicate methods for 'submitForm' and 'editForm'
d15d0c6
@tatilepizs
remove import that was not used ('commonPage')
8cbb350
@tatilepizs
Fix tests: nepali-dates-and-numbers, create-user-for-contacts.replace…
e7c27ec 
…-user, create-user-for-contacts.create-user, new-lineage-structure
@tatilepizs
organize test edi-report-with-attachment
93178a9
@tatilepizs
Clean and organize enketo-widgets e2e test
6c00813
@tatilepizs
Clean and organize extension-lib-form e2e test
4c0b90c
@tatilepizs
Fix enketo-widgets test
b3b2f4e
@tatilepizs
Fix enketo-widgets test - Try #2
0d8e5c1
@tatilepizs
Clean and organize pregnancy-complete-a-delivery e2e test
da54a8f
@tatilepizs
Remove commented code
8e207ff
@tatilepizs
Re-write the pregnancy-visit e2e test to use the form from the defaul…
7185aa3 
…t config - This will also cover the ticket #8603
@tatilepizs
Remove "submitButton" duplicate selector
8660da6
@tatilepizs
Clean and organize pregnancy e2e test
0bb2881
@tatilepizs
Moved the "create a pregnancy" section to the "it"
75a04b3
@tatilepizs
Running only the pregnancy-visit test
018cffe
@tatilepizs
Running only the pregnancy-visit test - new commit
8a7df40
@tatilepizs
Running only the pregnancy-visit test - try 2
f7bb467
@tatilepizs
Running only the pregnancy-visit test - try 3
6db8070
@tatilepizs
Running only the pregnancy-visit test - try 4 - skipping all the othe…
bc72323 
…r tests from enketo folder
@tatilepizs
Remove the .skip for all the enketo e2e tests except the pregnancy-fa…
32e616c 
…cility-visit-reminder to see if that test is causing the problem
@tatilepizs
Updates for the repeat test that I forgot to commit. Adding the await…
52be204 
… commonPage.waitForPageLoaded(); method in pregnancy-facility-visit-reminder.wdio-spec.js that might be causing the issue about the "Too Many Requests"
@tatilepizs
Remove the .skip
89f5943
@tatilepizs
Test: Add .skip to pregnancy-facility-visit-reminder.wdio-spec.js test
3aa1cb8
@tatilepizs
Clean and organize submit-form and submit-countdown-timer-forms e2e t…
3198fbb 
…ests
@tatilepizs
Merge branch 'master' of https://github.com/medic/cht-core into 8701-…
79927b6 
…clean-and-organize-enketo-folder
@tatilepizs
Add assessment.xml file
6876160
@tatilepizs
Adding a pause in the before section of the pregnancy-visit.wdio-spec.js
26239bb
@tatilepizs
Clean and organize submit-photo-upload-form and submit-z-score-form e…
a564a5b 
…2e test
@tatilepizs
Move the "browser.pause" at the beginning of the first individual test
e6f0ee2
@tatilepizs
Re-organize edit-report-with-attachment, submit-countdown-timer-form …
3a085f2 
…and submit-z-score-form.wdio-spec.js
@tatilepizs
Re-organize pregnancy-danger-sign-follow-up.wdio-spec.js
ac90b0b
@tatilepizs
Re-organize extension-lib-form.wdio-spec.js
6edd71d
@tatilepizs
Re-organize submit-photo-upload-form.wdio-spec.js
9f33119
@tatilepizs
Merge branch 'master' of https://github.com/medic/cht-core into 8701-…
1a1d0a9 
…clean-and-organize-enketo-folder
@tatilepizs
Clean and organize undo-death-report e2e test
2dc335b
@tatilepizs
Clean and organize training-cards e2e test
3137861
@tatilepizs
Clean and organize submit-default-delivery-form e2e test - The file w…
0c34a50 
…as deleted and the scenarios were included in pregnancy-complete-a-delivery test
@tatilepizs
Clean and organize page-objects files
017a677
@tatilepizs
Merge branch 'master' of https://github.com/medic/cht-core into 8701-…
3b991c9 
…clean-and-organize-enketo-folder
@tatilepizs tatilepizs marked this pull request as ready for review February 9, 2024 21:31
@tatilepizs
Copy link
Contributor Author

Hi @m5r, @jkuester,

This PR is ready for review, I didn't add you as reviewers but if you have time and can take a look at it it would be great.

Thank you 😊

@lorerod lorerod removed their request for review February 14, 2024 17:47
@lorerod lorerod mentioned this pull request Feb 14, 2024
Closed
5 tasks
lorerod
lorerod requested changes Feb 15, 2024
View reviewed changes
tests/e2e/default/enketo/extension-lib-form.wdio-spec.js Outdated Show resolved Hide resolved
tests/e2e/default/enketo/pregnancy-complete-a-delivery.wdio-spec.js Outdated Show resolved Hide resolved
tests/e2e/default/wdio.conf.js Outdated Show resolved Hide resolved
@lorerod lorerod self-requested a review February 15, 2024 18:18
@lorerod lorerod merged commit 343f163 into master Feb 15, 2024
30 checks passed
@lorerod lorerod deleted the 8701-clean-and-organize-enketo-folder branch February 15, 2024 21:11
This was referenced Apr 9, 2024
Closed
Closed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lorerod lorerod lorerod approved these changes

@ralfudx ralfudx Awaiting requested review from ralfudx

Assignees

@lorerod lorerod

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tatilepizs @lorerod