Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#7167): uplift cht-conf #8809

Merged
merged 2 commits into from
Jan 17, 2024
Merged

feat(#7167): uplift cht-conf #8809

merged 2 commits into from
Jan 17, 2024

Conversation

m5r
Copy link
Member

@m5r m5r commented Jan 15, 2024

Description

#7167

Code review checklist

  • Readable: Concise, well named, follows the style guide, documented if necessary.
  • Documented: Configuration and user documentation on cht-docs
  • Tested: Unit and/or e2e where appropriate
  • Internationalised: All user facing text
  • Backwards compatible: Works with existing data and configuration or includes a migration. Any breaking changes documented in the release notes.

Compose URLs

If Build CI hasn't passed, these may 404:

License

The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.

@m5r m5r marked this pull request as draft January 15, 2024 16:39
* upgrade cht-conf to latest 3.21.0

* replace medic-conf by cht-conf in build-config.sh

* kill unused script tests/apply-config.js

* fix cht-conf upload resources integration test

* fix cht-conf compile-app-settings integration test by installing a missing dependency

* install dependencies of default config before running tests in CI

* install dependencies of default config for real now

* install cht-conf from branch to see if it fixes previous issues

* upgrade cht-conf to 3.21.1

* remove unwanted changes

* fix path to cht-conf executable

* recompile app settings and forms

* stop using medic-conf (where is it coming from anyway? it's not installed anywhere)

* upgrade cht-conf in standard config

* revert standard config changes unrelated to the cht-conf upgrade

* chore(#7167): update dep versions for default/standard config (#8761)

---------

Co-authored-by: Joshua Kuestersteffen <[email protected]>
@m5r m5r marked this pull request as ready for review January 15, 2024 23:27
@m5r m5r requested a review from latin-panda January 16, 2024 09:19
@m5r
Copy link
Member Author

m5r commented Jan 16, 2024

@latin-panda could you review this please?

Copy link
Contributor

@latin-panda latin-panda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exciting! LGTM and works well!
Thanks!

@m5r m5r merged commit aef8973 into master Jan 17, 2024
31 checks passed
@m5r m5r deleted the 7167-uplift-cht-conf branch January 17, 2024 09:41
SheilaAbby pushed a commit to SheilaAbby/cht-core that referenced this pull request Feb 28, 2024
* chore(medic#7167): update dep versions for default/standard config (medic#8761)

* chore(medic#7167): migrate scripts depending on medic-conf (medic#8810)

* upgrade cht-conf to latest 3.21.0

* replace medic-conf by cht-conf in build-config.sh

* kill unused script tests/apply-config.js

* fix cht-conf upload resources integration test

* fix cht-conf compile-app-settings integration test by installing a missing dependency

* install dependencies of default config before running tests in CI

* install dependencies of default config for real now

* install cht-conf from branch to see if it fixes previous issues

* upgrade cht-conf to 3.21.1

* remove unwanted changes

* fix path to cht-conf executable

* recompile app settings and forms

* stop using medic-conf (where is it coming from anyway? it's not installed anywhere)

* upgrade cht-conf in standard config

* revert standard config changes unrelated to the cht-conf upgrade

* chore(medic#7167): update dep versions for default/standard config (medic#8761)

---------

Co-authored-by: Joshua Kuestersteffen <[email protected]>

---------

Co-authored-by: Joshua Kuestersteffen <[email protected]>

Support Making Countdown Widget a Required Field
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants