Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate using shellcheck for script linting #8557

Closed
garethbowen opened this issue Sep 19, 2023 · 0 comments
Closed

Investigate using shellcheck for script linting #8557

garethbowen opened this issue Sep 19, 2023 · 0 comments
Assignees
@mrjones-plip
Labels
Type: Technical issue Improve something that users won't notice
Milestone
4.9.0

Comments

@garethbowen
Copy link
Member

Describe the issue
Shell scripts are hard to validate, so if we can add linting or similar build time checks we can detect bugs before merging.

Describe the improvement you'd like
Try out https://www.shellcheck.net/

Describe alternatives you've considered
There may be other linting tools.
@garethbowen garethbowen added the Type: Technical issue Improve something that users won't notice label Sep 19, 2023
@nydr nydr self-assigned this Feb 19, 2024
@garethbowen garethbowen mentioned this issue May 23, 2024
Merged
23 tasks
@garethbowen garethbowen assigned mrjones-plip and unassigned nydr Jun 3, 2024
mrjones-plip added a commit that referenced this issue Jun 5, 2024
@nydr @mrjones-plip
chore(#8557): add linting for shell scripts (#9142)
9879478 
Co-authored-by: mrjones-plip <[email protected]>
@mrjones-plip mrjones-plip added this to the 4.9.0 milestone Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mrjones-plip mrjones-plip

Labels
Type: Technical issue Improve something that users won't notice
Projects
None yet
Milestone
4.9.0
Development

No branches or pull requests
3 participants
@garethbowen @mrjones-plip @nydr