Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: restore latest tag #2784

Merged
merged 4 commits into from
Dec 4, 2023
Merged

chore: restore latest tag #2784

merged 4 commits into from
Dec 4, 2023

Conversation

hay-kot
Copy link
Collaborator

@hay-kot hay-kot commented Dec 3, 2023

What type of PR is this?

(REQUIRED)

  • chore

What this PR does / why we need it:

(REQUIRED)

Updates workflows to

  1. Publish latest tag
  2. Publish to both ghcr and dockerhub

Ne because

  1. Some systems don't allow you to pull images easily from other registries besides dockerhub
  2. With the up-coming stable release, this will allow us to have a latest tag to recommend to users
  3. People big mad about us not having a latest tag.

Testing

I don't think there's really a way to test these without just pushing them to production :(

@Kuchenpirat
Copy link
Collaborator

i see no problems with this, should we just go full steam ahead and open the flood gates? 🚀

@michael-genson
Copy link
Collaborator

+1 to pushing and dealing with it later if it's a problem. I don't see a cleaner path forward

@hay-kot hay-kot enabled auto-merge (squash) December 4, 2023 18:53
@hay-kot hay-kot merged commit b369417 into mealie-next Dec 4, 2023
11 checks passed
@hay-kot hay-kot deleted the chore/restore-latest-tag branch December 4, 2023 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants