MCC-984635 #82
MCC-984635 #82
Conversation
|
@jfeltesse-mdsol I wonder if we encourage this anymore? |
There was a problem hiding this comment.
If @jfeltesse-mdsol thinks it's ok to keep using Kender,
please update the CHANGELOG.md as well
README.md
Outdated
| #### cypress-rails | ||
|
|
||
| Your application should include the following task `rake cypress_extended:enhanced_run`. | ||
| Please check how was implemented in broadacre. |
There was a problem hiding this comment.
Is this line about broadacre is relevant? Shouldn't people be able to figure out how to use cypress-rails from the gem homepage?
There was a problem hiding this comment.
Added an example 😄
|
If people find it useful and just like in this PR, keep contributing to it, I think there's no benefit in sunsetting a tool that Just Works™. Thanks for the PR @vlazartranscenda ! |
2d332e4
to
05b214f
Compare
| @@ -206,6 +206,23 @@ If there is no `factory_girl_lint.rake` file in the `lib/tasks` directory of the | |||
|
|
|||
| [fgl]: https://github.com/thoughtbot/factory_girl/blob/master/GETTING_STARTED.md#linting-factories | |||
|
|
|||
| #### Cypress-Rails | |||
|
|
|||
| Your application should include the following task `rake cypress_extended:enhanced_run` | |||
There was a problem hiding this comment.
Ah, ok, thanks for this explanation. I don't know anything about Cypress-Rails to know if this pattern is standard, but if someone else wants to use Cypress-Rails with Kender later and doesn't like this pattern, it can be discussed then 😄
There was a problem hiding this comment.
Before running the cypress command I also need to start the react app. And I also want to use kender since all the other tests run from here. So my idea was to create another rake task which includes the cypress one, like in the example.
4174d67
to
1cd4398
Compare
Yes. It works -> https://app.travis-ci.com/github/mdsol/broadacre/builds/257557867 . Can I merge it or will someone else do? Thank you! |
|
Can you review/merge #83 so I can tag 0.7.0 once it's in? I'd like to get both PRs for the same version bump. |
for me the changes look good but I am not part of the Contributors. I am not sure who should merge it 🤔 |
We want to use cypress-rails in our ci and this is the best way to run it. Like we run the other commands.
https://jira.mdsol.com/browse/MCC-984635