Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to GHA #47

Merged
merged 2 commits into from
Aug 25, 2022
Merged

Switch to GHA #47

merged 2 commits into from
Aug 25, 2022

Conversation

ewu63
Copy link
Collaborator

@ewu63 ewu63 commented Aug 25, 2022

Purpose

Closes #46. Coverage doesn't work yet but that should be addressed separately (tracked in #48).

Expected time until merged

1 week.

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Checklist

  • I have run flake8 and black to make sure the code adheres to PEP-8 and is consistently formatted
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@ewu63 ewu63 requested a review from a team as a code owner August 25, 2022 15:25
Copy link
Contributor

@marcomangano marcomangano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I assume the pypi task is skipped because we only want to publish after the merge with main, right?
Where is that instruction coming from?

@ewu63
Copy link
Collaborator Author

ewu63 commented Aug 25, 2022

LGTM I assume the pypi task is skipped because we only want to publish after the merge with main, right? Where is that instruction coming from?

PyPI upload only happens on tagged releases, not on every push to main. The logic that controls that is found here.

@marcomangano marcomangano merged commit 4195146 into main Aug 25, 2022
@marcomangano marcomangano deleted the use-GHA branch August 25, 2022 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch to GHA
2 participants