Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO NOT MERGE YET: Add cross-document view transitions demo #265

Merged
merged 6 commits into from
Jun 23, 2024

Conversation

chrisdavidmills
Copy link
Contributor

@chrisdavidmills chrisdavidmills commented Mar 15, 2024

Note: DO NOT MERGE until after the corresponding content updates in mdn/content#32723 have been merged, as this PR will break the demo links in the current content.

This PR adds a basic cross-document (MPA) view transitions demo to the repo.

It reorganizes the repo a bit, so that the existing SPA view transitions demo is put in a separate spa folder, and the new one in an mpa folder.

Note that as of March 25th, these features only work in Chrome with chrome:https://flags/#view-transition-on-navigation flag enabled.

Related PRs:

Copy link
Member

@pepelsbey pepelsbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just a few ideas how to improve it a bit :)

README.md Show resolved Hide resolved
view-transitions/mpa/index.js Outdated Show resolved Hide resolved
view-transitions/mpa/styles.css Outdated Show resolved Hide resolved
@chrisdavidmills chrisdavidmills changed the title Add cross-document view transitions demo DO NOT MERGE YET: Add cross-document view transitions demo Mar 25, 2024
@chrisdavidmills
Copy link
Contributor Author

@pepelsbey please can you approve this one so we can get it merged? Otherwise the demo links will be broken in the view transitions docs updates. Thanks!

Copy link
Member

@pepelsbey pepelsbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pepelsbey pepelsbey merged commit 4c1e311 into mdn:main Jun 23, 2024
3 checks passed
@chrisdavidmills chrisdavidmills deleted the cross-document-view-transitions branch June 23, 2024 17:22
@chrisdavidmills
Copy link
Contributor Author

Thanks!

@pepelsbey yay, cheers mate!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants