Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(css): add more syntax examples to font-variant-ligatures #34618

Merged
merged 3 commits into from
Jul 18, 2024
Merged

fix(css): add more syntax examples to font-variant-ligatures #34618

merged 3 commits into from
Jul 18, 2024

Conversation

OnkarRuikar
Copy link
Contributor

@OnkarRuikar OnkarRuikar requested a review from a team as a code owner July 4, 2024 09:56
@OnkarRuikar OnkarRuikar requested review from chrisdavidmills and removed request for a team July 4, 2024 09:56
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs size/s [PR only] 6-50 LoC changed labels Jul 4, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 4, 2024 •
edited
Loading

Preview URLs

Flaws (1)

URL: /en-US/docs/Web/CSS/font-variant-ligatures
Title: font-variant-ligatures
Flaw count: 1

  • macros:
    • /en-US/docs/Glossary/contextual_forms does not exist

(comment last updated: 2024-07-18 11:38:54)

chrisdavidmills
chrisdavidmills requested changes Jul 6, 2024
View reviewed changes
Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, @OnkarRuikar. I've got a comment for you below, plus, as the issue says, the description of the syntax values is incorrect and should also be updated:

The font-variant-ligatures property is specified as one of the keyword values listed below.

How about something like:

The font-variant-ligatures property is specified as normal, none, or one or more of the other value types listed below, separated by spaces.

?

files/en-us/web/css/font-variant-ligatures/index.md Outdated Show resolved Hide resolved
chrisdavidmills
chrisdavidmills approved these changes Jul 18, 2024
View reviewed changes
Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks @OnkarRuikar. I corrected a couple of very small typos and grammatical bits, and now I think we can merge. Good job!

@chrisdavidmills chrisdavidmills merged commit 8d8f3f4 into mdn:main Jul 18, 2024
8 checks passed
@OnkarRuikar OnkarRuikar deleted the css_font_variant_ligatures branch July 18, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisdavidmills chrisdavidmills chrisdavidmills approved these changes

Assignees
No one assigned
Labels
Content:CSS Cascading Style Sheets docs size/s [PR only] 6-50 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

font-variant-ligatures doesn't describe combining values
2 participants
@OnkarRuikar @chrisdavidmills