Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor and fix handling of goodreads api when currently reading contains a single item #2

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Refactor and fix handling of goodreads api when currently reading contains a single item #2

wants to merge 2 commits into from

Commits on Nov 17, 2020

  1. Refactor the code to follow a more modular design 

    - Put all goodreads api related methods in a dedicated class
- Put all github api related methods in a dedicated class
- Put all output formatting in a dedicated class
- Prepare the ground for dependency injection and more increased
testability
- Didn't change any behavior

This commit is intended to prepare future work. Design choices made here
are also a matter of preference.
    @AntoineDrouhin
    AntoineDrouhin committed Nov 17, 2020
    Configuration menu
    Copy the full SHA
    8e24697 View commit details
    Browse the repository at this point in the history

  2. fix - handle single review result 

    When getting reviews from goodreads api, if a single result was
returned, it was not returned as an array. I fixed this by casting the result to an array.
    @AntoineDrouhin
    AntoineDrouhin committed Nov 17, 2020
    Configuration menu
    Copy the full SHA
    e18e7ee View commit details
    Browse the repository at this point in the history