Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added exception for TypeError #47

Merged
merged 1 commit into from
Mar 18, 2021
Merged

Added exception for TypeError #47

merged 1 commit into from
Mar 18, 2021

Conversation

FrescoFlacko
Copy link
Contributor

Added exception for TypeError when splitting subsets

Added exception for TypeError when splitting subsets
@mdeff
Copy link
Owner

mdeff commented Sep 22, 2020

Can you paste here the exact exception you got? What where you doing that triggered the exception? Which version of pandas were you using?

@mdeff mdeff self-requested a review September 22, 2020 22:36
@mdeff mdeff marked this pull request as draft September 22, 2020 22:37
@mdeff mdeff closed this Oct 22, 2020
@mdeff mdeff reopened this Mar 18, 2021
@mdeff
Copy link
Owner

mdeff commented Mar 18, 2021

Okay so newer versions of pandas throw a TypeError [#34 (comment)] instead of a ValueError (which was only during the deprecation period?). Thanks for the fix!

@mdeff mdeff marked this pull request as ready for review March 18, 2021 22:34
@mdeff mdeff merged commit 422ffcc into mdeff:next Mar 18, 2021
mdeff added a commit that referenced this pull request Mar 18, 2021
Added exception for TypeError, thrown by newer pandas
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants