New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tests pass under `-c opt` #24

Merged

mcy merged 4 commits into main from opt

Jul 11, 2024

Owner

mcy commented Jul 11, 2024

Make everything pass with optimizations turned on. This revealed two UB bugs:

best::vec<T> was manipulating size_ directly, even when this would violate strict aliasing. This caused some tests to fail because loading size_ would ignore stores made through data(), because &size_ and data() cannot alias because they have different types. size_ is now manipulated exclusively through memcpy().
A UAF in fnref_test.cc (but not best::fnref itself).

Since I was already touching best::fnref, I added a small optimization when constructing a best::fnref from a no-capture lambda.

mcy added 4 commits

July 11, 2024 13:59


make everything build under opt

48a1117


enforce via ci

ecd6dce


make sure best::vec never touches size_ directly

e27247c


make sure best::vec never touches size_ directly

098326e

mcy merged commit 67e43b2 into main

3 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment