Fix: Promptbar initializes in open state for Mobile #542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ipeblb
added a commit
to ipeblb/chatbot-ui
that referenced
this pull request
Apr 18, 2023
* Update Bangla Translation (mckaywrigley#546) * Fix: Promptbar initializes in open state for Mobile (mckaywrigley#542) * Fix for DEFAULT_SYSTEM_PROMPT * Set the prompt bar to be hidden if screen < 640 * feature: 右columnにDocument upload用のエリアを追加 * feature: fileをアップロードするエリアを作成 * fix: Fileがtsですでに宣言済みだったため、名前を一部修正 * chore: langchain, pdfjs-distをinstall * feature: upload用のendpoint作成 * feature: vectorstoreを生成するところまで * feature: 作成したindexをlocalstorageに格納 * fix: アップロードをキャンセルした時の挙動を修正 * feature: 裏側のapiが動くところまで * feature: frontに回答を送信できるように * fix: responseが必ず閉じるように修正、payloadのlimit解放 * feature: filenameをmetadataとして渡す+idとして利用 * fix: 型エラー解消のためnullの代わりに空文字を渡す * feature: add plugin * fix: initial load files * feature: validation and loading icon * chore: prompt微調整 * feature: pluginでQA出し分けできるように修正 * feature: 雑に諸々ハンドリング ---------
HaRuKa-1231
pushed a commit
to HaRuKa-1231/chatbot-ui
that referenced
this pull request
Apr 20, 2023
* Update Bangla Translation (mckaywrigley#546) * Fix: Promptbar initializes in open state for Mobile (mckaywrigley#542) * Fix for DEFAULT_SYSTEM_PROMPT * Set the prompt bar to be hidden if screen < 640 * feature: 右columnにDocument upload用のエリアを追加 * feature: fileをアップロードするエリアを作成 * fix: Fileがtsですでに宣言済みだったため、名前を一部修正 * chore: langchain, pdfjs-distをinstall * feature: upload用のendpoint作成 * feature: vectorstoreを生成するところまで * feature: 作成したindexをlocalstorageに格納 * fix: アップロードをキャンセルした時の挙動を修正 * feature: 裏側のapiが動くところまで * feature: frontに回答を送信できるように * fix: responseが必ず閉じるように修正、payloadのlimit解放 * feature: filenameをmetadataとして渡す+idとして利用 * fix: 型エラー解消のためnullの代わりに空文字を渡す * feature: add plugin * fix: initial load files * feature: validation and loading icon * chore: prompt微調整 * feature: pluginでQA出し分けできるように修正 * feature: 雑に諸々ハンドリング ---------
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another simple fix. Currently when loading the ui on mobile the prompt launches in an open state. I fixed this issue by implementing the same approach that the chatbar uses.
Issue: Promptbar launches in an open state on mobile
Repro: In a new incognito (need a clean localstorage) launch the ui on a window smaller than 640px
Fix: Implement the same approach as the chatbar