Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for prefers-reduced-motion #61

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add support for prefers-reduced-motion #61

wants to merge 2 commits into from

Conversation

Muhnad
Copy link

@Muhnad Muhnad commented Sep 30, 2020

@mciastek
Copy link
Owner

mciastek commented Oct 4, 2020

Thank you for submitting this PR. I think that implementation of reduced motion support is not yet ready for sal.js. We need to check for reduced motion on load, but also when it changes. This requires adding a change listener. In my opinion, it's too much for such small library. Additionally, nothing stops a developer adding such kind of support by themselves. There's a required API (disable and enable methods), so this feature can be implemented outside of sal.

I do like your changes in README, so I'd like to ask you to create a separate PR with documentation changes. I appreciate it. Thank you!

@Muhnad
Copy link
Author

Muhnad commented Oct 15, 2020 via email

@mciastek mciastek mentioned this pull request Dec 13, 2020
@mciastek mciastek added this to To Do in Roadmap Dec 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Roadmap
To Do
Development

Successfully merging this pull request may close these issues.

None yet

2 participants