Fix exceptions when shooting entities through worlds on folia #5024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nossr50
reviewed
Aug 28, 2024
| @@ -287,6 +287,9 @@ public void attackTarget(LivingEntity target) { | |||
| double range = 5; | |||
| Player player = getPlayer(); | |||
|
|
|||
| if (!target.getWorld().equals(player.getWorld())) | |||
There was a problem hiding this comment.
When would a player's world not equal their targets?
There was a problem hiding this comment.
It's possible to shoot an arrow through a nether portal and hit an entity on the other side of it
There was a problem hiding this comment.
Thank you for that information!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AwardCombatXpTask checks the target's health to see how much damage was done, but running this on the player's scheduler can cause exceptions if the target is not in the same region, like if the target is on the other side of a nether portal.