Better shortcuts #1206
Merged
Better shortcuts #1206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 1, 2023 03:29
Currently, the mozilla documentation states that for secondary modifiers: If supplied, this must be either "Shift" or (for Firefox ≥ 63) any one of "Ctrl", "Alt", "Command", or "MacCtrl". Must not be the modifier already used as the main modifier. This commit adds Ctrl, Command, and MacCtrl to the list of allowed secondary modifiers, allowing stuff like MacCtrl+Ctrl+Period as a binding. Of course, that renders quite confusingly (Ctrl+Ctrl+Period), but at least we can now accept the bindings.
Instead of rendering MacCtrl as Ctrl, which can cause confusion when Command gets mapped to Ctrl instead of Command, this instead renders it as UTF 2303 Up Arrowhead (⌃), which is the character that MacOS appears to use for showing macctrl in bindings. I'm not sure why they are using Up Arrowhead instead of circumflex accent (^), but, eh, it works.
|
Great, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the mozilla documentation states that for secondary modifiers:
This commit adds Ctrl, Command, and MacCtrl to the list of allowed secondary modifiers, allowing stuff like MacCtrl+Ctrl+Period as a binding.
Of course, that renders quite confusingly (Ctrl+Ctrl+Period), so I did a second change to render MacCtrl as ⌃, which is UTF 2302 Up Arrowhead. This appears to be what MacOS is using to render it.
At the very least, it's the symbol they use on their website for it. :)
This gives us ⌃+Ctrl+Period, which is at least less confusing, even if I wish that Command came through as Command.