-
-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request] Show tab's preview on hover #301
Comments
@mbnuqw Would it be possible to implement this feature some day? Thanks |
I'd like to, but I don't know yet how to properly implement this feature. There are different ways, but each has essential (from my point of view) drawbacks: Preview in window (like in Vivaldi or Edge)Pros:
Cons:
1.mp4Preview in popup inside sidebarPros:
Cons:
2.mp4Preview in every tab (like in Visual Tabs)Pros:
Cons:
So, I'll continue to experiment with this... |
"Preview in popup inside sidebar" seems more reactive than "Preview in window" and no flickering. So I prefer the second option ("Preview in popup inside sidebar"). |
@mbnuqw However, I wanted to point out that by 3 (Visual Tabs-like approach) I actually meant that previews should be revealed on hover, not always visible on all tabs — extension has an option for this: video.mp4This way discarded tabs, which don't provide any preview, simply will not expand on mouse hover. |
Looking forward to this so very much. It's a fantastic Vivaldi feature, sorely missed in FF, so if |
Firefox's MRU tab switcher has previews and for me it's the only ones I really would preview since I have very aggressive tab unloading policies (95% of my tabs are unloaded) with ATD. Definitely would prefer the 1st option to make things more readable if it doesn't affect performance negatively too much. |
Option 1 would be best, as it doesn't affect the sidebar's usability. The flickering is annoying though. Next best is option 2 imo, since adding the preview to the tooltip isn't too bad when it comes to usability. Option 3, where tabs change size when you hover over them, seems like it would have a lot of usability issues. Every time you hover over a tab, it looks like you triple the distance to the next tab. |
By the way, it seems that this bug has been resolved 2 months ago... |
OMZ, does this mean that in fact, Sidebery can now have tab hover thumbnails... or i'm misunderstanding? |
@guigirl42 Nah, it only means that "undesirable movement on show" is probably gone now. But the titlebar issue of the 1st approach is still there though |
Oh rats. How disappointing. Sidebery is a major part of why, after many years of being an avid Vivaldi fangirl, i switched to FF Nightly. It's so great. That said, the idea of it one day maybe also gaining tab hover thumbnails is quite intoxicating... 🤞 |
@emvaized thanks for the info, I'll test this (as well as the variant with the inline preview). btw, what aspects of this feature would you like to be configurable? Like, delay before showing, size of preview popup, maybe, some additional info in that popup? |
Oooh, now i am getting excited again! 🤞 |
Configurable delay before showing sounds great! Probably, the most imprortant option for this feature |
All quiet here; is this request likely to be available for Beta-testing soon-ish pls? 🤷♀️ |
Today i discovered this AddOn; https://addons.mozilla.org/en-US/firefox/addon/tab-preview-on-hover/, & it made me feel excited. I was thinking to install it, til i suddenly realised... "d'oh, it's coded for FF's native horizontal tabs, so it surely cannot work for Sidebery". I assume that's true? If so, is there any part of its code that can be borrowed & modified for Sidebery? |
|
Congratulations on your recent release of v5 Stable. Marvellous achievement! 🎉 So, now... 😉 🤞 |
There was an old Firefox extension called Tree Style Tab that had support for thumbnails inside the vertical tabs via Informational Tab. Aldo this issue is about thumbnails on hover, showing it inside the vertical tab would be a nice feature for this addon and won't require a popover component. |
I have tried this in my |
@guigirl42 |
So, another round of experiments with this feature for a couple of hours, which smoothly turned into a couple of days, resulted in something more or less functional. Implemented two modes: inline (Visual Tabs-like) and popup. Will be released for testing in v5.1.1.2 tomorrow (or to be precise when I setup the auto-releasing of the "GitHub" version, which I have planned for tomorrow) Inline mode:Peek.2024-02-13.21-16.mp4Popup mode:Peek.2024-02-13.21-17.mp4(Some artifacts and glitches are results of crappy recording...) Of course, there are possible bugs or maybe unexpected behavior, so feedback is welcome. |
Oh wow, this is exciting news indeed; thank you! ❤️ I shall be selecting/using the |
Is there no way to just inject a div into the page area with very strict css rules to create the desired appearance? It seems like creating a new window is pretty clunky on anything except a few IDEs. |
@jathek, it won't work for all pages - for privileged Mozilla pages, Firefox pages, pages of other addons, local file pages. Although, in these cases I can just fall back to the current external window mode. I'll try it out.
That's why "popup" mode is experimental and will remain so even after release. (I'll add a note in settings page) |
sidebery.mp4Tested in new profile, Firefox nightly, on Windows 11. |
I can also reproduce this error in Firefox 122.0.1 on Debian sid, although not the new profile. |
Just for the record, 5.1.1.4 |
This morning i got 5.1.1.5 & was momentarily displeased when i realised it had reset my preference from the popup window, to inline. However once i went into Settings to change it back, i realised why it happened, & have now happily chosen your new option |
I found a slightly annoying UI problem caused by focus stealing. When you click the "Open a new tab" button in the sidebar, the mouse points to the last tab, so it interrupts you in the middle of typing in the browser address bar when it pops up. |
@dexeonify, is this a userChrome.css? Completely forgot about auto-hide-sidebar modifications, so I'll add horizontal offset too. @gepz, right, I should ignore active tab since it's pointless to show preview for it. This will solve the issue for the cases when a new tab is placed at the end of the list (and goes right under the cursor). Otherwise, use non-window mode. |
I've been loving the new popup-in-page option, it's exactly what I was hoping for.
@dexeonify for now I have been using this small code in my userContent.css to fix margins: /* --------------------- fix margin for in-page tab preview */
:root {
--sdbr-tabs-margin: 6px;
}
#sdbr_preview_root {
margin-right: calc(var(--sdbr-tabs-margin) - 2px) !important;
} Edit: The popup has a "right" property of 2px by default, so I edited my style to remove that and get exactly the margin I want. |
If the popup isn't shown for some reason (protected page, discarded tab), can the normal tooltip be shown? |
new crop feature from f648741 works great 👍 |
To achieve this on Windows you will likely need 3rd party window managers which can disable frames for specific type of windows. I could achieve it using something like Actual Window Manager, but it's a paid app (I think there might be free alternatives out there) |
Basically, it's #380. Workaround is #380 (comment). (I've already added a task to expose that hidden setting, so this will be simpler in the next release) Closing this issue as implemented. |
Wow guys, I've tried plenty of tab preview extensions (Visual Tabs being the best of them all), but my love for vertical tree-style tabs has always been more than that for previews, so always been making that compromise. Just tried Sidebery's Tab Previews and I'm flabbergasted! Why does anyone still use TST? Why does anyone still use any other browser than Firefox? I'm guessing they just don't know how Sidebery can utterly change their life for the better yet... One thing,
It is my opinion that with previews, the bigger the better, ALWAYS. But if it's not theoretically possible, no big deal; it's already working wonders!!! |
Description
As it can be seen, Sidebery already can store tab's screenshots, to display them in tab group overview (when in list mode).
So it will be awesome to show a small popup on tab's hover containing preview of tab's content, as well as title and favicon.
I think of a great example of this feature in Vivaldi browser:
The text was updated successfully, but these errors were encountered: