Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

single spec for all literal tests #318

Merged
merged 1 commit into from
Apr 28, 2015
Merged

single spec for all literal tests #318

merged 1 commit into from
Apr 28, 2015

Conversation

kbrock
Copy link
Contributor

@kbrock kbrock commented Apr 26, 2015

This code confuses me, as 99% of the time, there is a single spec per lib file.
Textmate and sublime uses this assumption to switch between tests too.

Do these really need to be separate files?

Is the problem here that the test app is too simple?

@mbj
Copy link
Owner

mbj commented Apr 27, 2015

Do these really need to be separate files?

No, the fact these are separate files is from a very ancient mutant version that did use the file name as matching criteria.

Is the problem here that the test app is too simple?

The test app is a minimal integration test. It should have the following sematics under mutation testing:

  • A fully covered subject
  • A partially covered subject
  • Does not maintain mutable global state
  • Has instance methods
  • Has singleton methods
  • (future) has subjects with failing tests

What kind of mutations are happending is not important (anymore), since the full mutation specification is in the mutant-meta so mutation wise it should NOT be exhaustive.

@mbj
Copy link
Owner

mbj commented Apr 27, 2015

@kbrock After I pushed c392cb5 this does not merge clearly anymore. The rebase on your side should be trivial as I only nuked redundant encoding headers.

mbj added a commit that referenced this pull request Apr 28, 2015
single spec for all literal tests
@mbj mbj merged commit ce8dfea into mbj:master Apr 28, 2015
@kbrock kbrock deleted the test_app_specs branch April 28, 2015 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants