-
-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use actor based parallelization #266
Conversation
:( |
@plexus See it terminated ;) |
\o/ lol |
@plexus My whole point was to make the error visible in the first step. I really hate systems that do not blow up. The complex interactions between the inner (killfork isolation) and the outer one (for parallelization) did hide this error before. |
f85edcc
to
949c5d6
Compare
a133c5a
to
4266022
Compare
6ec41df
to
b657d15
Compare
7e7b75d
to
1c7b087
Compare
3f60518
to
39ad443
Compare
@plexus The current state of this branch implements everything I wanted it to do. It includes the concurency semantics of master plus per worker reporting and some parallel related bugfixes (via removing it). If you wanted you could run it to give it some testing. |
end # Message | ||
|
||
# Undefined message payload | ||
module Undefined |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does Undefined
need to be a module? Would it be more lightweight to use Undefined = BasicObject.new
or something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dkubb You get a sane #inspect
for free this way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But I agree Module
has too much public interface (I initially used Class
). I'll use an anonymous object instance with an explicit #inspect
defined.
@mbj I finished a pass over the code. |
79f7a96
to
ff7177a
Compare
1020ff9
to
a29d799
Compare
parrallel
execution. (good thing)parallel
. (good thing)Mutant::Mutation
instances serializable, reduces building partial result objects to make them transmittable overparallel
's interfaces. (good thing)