Fix coverage #1445
Merged
Fix coverage #1445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbj
commented
May 12, 2024
| @@ -12,9 +12,12 @@ module Util | |||
| # | |||
| # @return [Object] first entry | |||
| def self.one(array) | |||
| return array.first if array.one? | |||
There was a problem hiding this comment.
Array#one? comes form Enumerable#one? which returns true if there is one item that returns truthy. So [nil].one? would return false which is not the intention of this code.
There is no call side in mutant that would have been affected by the behavior difference, still it has to be fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.