Fallback to mediump precision for device that doesn't support highp #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @garyyeap, thanks for the PR. Why did you close the PR? |
|
@mbebenita btw i have some pending changes i want to submit to broadway. thats why i havent integrated the prs yet. |
|
@mbebenita Thanks for replying me, this is the wrong commit containing a bug, I recreated another opening PR #109 for the same issue, just ignoring this one or just feel free to delete it(I'm not sure if is deletable). |
|
@garyyeap ah, I see. When you close a PR, you can just comment on why it's being closed. That should be good enough. Thanks. |
|
@mbebenita Got it, sorry for the inconvenience. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested on Nexus 7 2012
http:https://chromium-bugs.chromium.narkive.com/XAitJUY1/issue-245755-in-chromium-webgl-regression-highp-precision-is-not-supported-in-fragment-shader