Skip to content

Commit

Permalink
[hotfix][build] Clarify purpose of build-helper-maven-plugin
Browse files Browse the repository at this point in the history
  • Loading branch information
@zentol
zentol committed Nov 1, 2022
1 parent 4e860b6 commit ef05f04
Show file tree
Hide file tree
Showing 9 changed files with 33 additions and 25 deletions.
5 changes: 3 additions & 2 deletions flink-connectors/flink-hadoop-compatibility/pom.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -167,12 +167,13 @@ under the License.
</configuration>
</plugin>

<!-- Adding scala source directories to build path -->
<!-- Adding scala source directories to build path
This is required for the source jar -->
<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>build-helper-maven-plugin</artifactId>
<executions>
<!-- Add src/main/scala to eclipse build path -->
<!-- Add src/main/scala to build path -->
<execution>
<id>add-source</id>
<phase>generate-sources</phase>
Expand Down
7 changes: 4 additions & 3 deletions flink-end-to-end-tests/flink-end-to-end-tests-scala/pom.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -183,12 +183,13 @@ under the License.
</configuration>
</plugin>

<!-- Adding scala source directories to build path -->
<!-- Adding scala source directories to build path
This is required for the source jar -->
<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>build-helper-maven-plugin</artifactId>
<executions>
<!-- Add src/main/scala to eclipse build path -->
<!-- Add src/main/scala to build path -->
<execution>
<id>add-source</id>
<phase>generate-sources</phase>
Expand All @@ -201,7 +202,7 @@ under the License.
</sources>
</configuration>
</execution>
<!-- Add src/test/scala to eclipse build path -->
<!-- Add src/test/scala to build path -->
<execution>
<id>add-test-source</id>
<phase>generate-test-sources</phase>
Expand Down
7 changes: 4 additions & 3 deletions flink-examples/flink-examples-batch/pom.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -146,12 +146,13 @@ under the License.
</configuration>
</plugin>

<!-- Adding scala source directories to build path -->
<!-- Adding scala source directories to build path
This is required for the source jar -->
<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>build-helper-maven-plugin</artifactId>
<executions>
<!-- Add src/main/scala to eclipse build path -->
<!-- Add src/main/scala to build path -->
<execution>
<id>add-source</id>
<phase>generate-sources</phase>
Expand All @@ -164,7 +165,7 @@ under the License.
</sources>
</configuration>
</execution>
<!-- Add src/test/scala to eclipse build path -->
<!-- Add src/test/scala to build path -->
<execution>
<id>add-test-source</id>
<phase>generate-test-sources</phase>
Expand Down
7 changes: 4 additions & 3 deletions flink-examples/flink-examples-streaming/pom.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -457,12 +457,13 @@ under the License.
</configuration>
</plugin>

<!-- Adding scala source directories to build path -->
<!-- Adding scala source directories to build path
This is required for the source jar -->
<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>build-helper-maven-plugin</artifactId>
<executions>
<!-- Add src/main/scala to eclipse build path -->
<!-- Add src/main/scala to build path -->
<execution>
<id>add-source</id>
<phase>generate-sources</phase>
Expand All @@ -475,7 +476,7 @@ under the License.
</sources>
</configuration>
</execution>
<!-- Add src/test/scala to eclipse build path -->
<!-- Add src/test/scala to build path -->
<execution>
<id>add-test-source</id>
<phase>generate-test-sources</phase>
Expand Down
4 changes: 2 additions & 2 deletions flink-libraries/flink-cep-scala/pom.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ under the License.
<groupId>org.codehaus.mojo</groupId>
<artifactId>build-helper-maven-plugin</artifactId>
<executions>
<!-- Add src/main/scala to eclipse build path -->
<!-- Add src/main/scala to build path -->
<execution>
<id>add-source</id>
<phase>generate-sources</phase>
Expand All @@ -157,7 +157,7 @@ under the License.
</sources>
</configuration>
</execution>
<!-- Add src/test/scala to eclipse build path -->
<!-- Add src/test/scala to build path -->
<execution>
<id>add-test-source</id>
<phase>generate-test-sources</phase>
Expand Down
7 changes: 4 additions & 3 deletions flink-scala/pom.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -227,12 +227,13 @@ under the License.
</configuration>
</plugin>

<!-- Adding scala source directories to build path -->
<!-- Adding scala source directories to build path
This is required for the source jar -->
<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>build-helper-maven-plugin</artifactId>
<executions>
<!-- Add src/main/scala to eclipse build path -->
<!-- Add src/main/scala to build path -->
<execution>
<id>add-source</id>
<phase>generate-sources</phase>
Expand All @@ -245,7 +246,7 @@ under the License.
</sources>
</configuration>
</execution>
<!-- Add src/test/scala to eclipse build path -->
<!-- Add src/test/scala to build path -->
<execution>
<id>add-test-source</id>
<phase>generate-test-sources</phase>
Expand Down
7 changes: 4 additions & 3 deletions flink-streaming-scala/pom.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -220,12 +220,13 @@ under the License.
</configuration>
</plugin>

<!-- Adding scala source directories to build path -->
<!-- Adding scala source directories to build path
This is required for the source jar -->
<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>build-helper-maven-plugin</artifactId>
<executions>
<!-- Add src/main/scala to eclipse build path -->
<!-- Add src/main/scala to build path -->
<execution>
<id>add-source</id>
<phase>generate-sources</phase>
Expand All @@ -238,7 +239,7 @@ under the License.
</sources>
</configuration>
</execution>
<!-- Add src/test/scala to eclipse build path -->
<!-- Add src/test/scala to build path -->
<execution>
<id>add-test-source</id>
<phase>generate-test-sources</phase>
Expand Down
7 changes: 4 additions & 3 deletions flink-tests/pom.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -372,12 +372,13 @@ under the License.
</configuration>
</plugin>

<!-- Adding scala source directories to build path -->
<!-- Adding scala source directories to build path
This is required for the source jar -->
<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>build-helper-maven-plugin</artifactId>
<executions>
<!-- Add src/main/scala to eclipse build path -->
<!-- Add src/main/scala to build path -->
<execution>
<id>add-source</id>
<phase>generate-sources</phase>
Expand All @@ -390,7 +391,7 @@ under the License.
</sources>
</configuration>
</execution>
<!-- Add src/test/scala to eclipse build path -->
<!-- Add src/test/scala to build path -->
<execution>
<id>add-test-source</id>
<phase>generate-test-sources</phase>
Expand Down
7 changes: 4 additions & 3 deletions flink-yarn-tests/pom.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -315,12 +315,13 @@ under the License.
</configuration>
</plugin>

<!-- Adding scala source directories to build path -->
<!-- Adding scala source directories to build path
This is required for the source jar -->
<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>build-helper-maven-plugin</artifactId>
<executions>
<!-- Add src/main/scala to eclipse build path -->
<!-- Add src/main/scala to build path -->
<execution>
<id>add-source</id>
<phase>generate-sources</phase>
Expand All @@ -333,7 +334,7 @@ under the License.
</sources>
</configuration>
</execution>
<!-- Add src/test/scala to eclipse build path -->
<!-- Add src/test/scala to build path -->
<execution>
<id>add-test-source</id>
<phase>generate-test-sources</phase>
Expand Down

0 comments on commit ef05f04

Please sign in to comment.