[Flink-11315] Make magic number in KvStateSerializer as a constant va…

…lue to make more readable (apache#7482) This closes apache#11315
mbalassi · Feb 7, 2019 · e6a318c · e6a318c
1 parent 1b71e44
commit e6a318c
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/...in/java/org/apache/flink/queryablestate/client/state/serialization/KvStateSerializer.java b/...in/java/org/apache/flink/queryablestate/client/state/serialization/KvStateSerializer.java
@@ -35,6 +35,8 @@
  */
 public final class KvStateSerializer {
 
+ //The magic number is as a flag between key and namespace.
+ private static final int MAGIC_NUMBER = 42;
  // ------------------------------------------------------------------------
  // Generic serialization utils
  // ------------------------------------------------------------------------
@@ -63,7 +65,7 @@ public static <K, N> byte[] serializeKeyAndNamespace(
  DataOutputSerializer dos = new DataOutputSerializer(32);
 
  keySerializer.serialize(key, dos);
- dos.writeByte(42);
+ dos.writeByte(MAGIC_NUMBER);
  namespaceSerializer.serialize(namespace, dos);
 
  return dos.getCopyOfBuffer();
@@ -93,7 +95,7 @@ public static <K, N> Tuple2<K, N> deserializeKeyAndNamespace(
  try {
  K key = keySerializer.deserialize(dis);
  byte magicNumber = dis.readByte();
- if (magicNumber != 42) {
+ if (magicNumber != MAGIC_NUMBER) {
  throw new IOException("Unexpected magic number " + magicNumber + ".");
  }
  N namespace = namespaceSerializer.deserialize(dis);