[FLINK-26054][build] Add enforcer rule to forbid direct dependency on…

… table planner

flink-connectors/flink-connector-cassandra/pom.xml

@@ -164,14 +164,6 @@ under the License.
  <scope>provided</scope>
  <optional>true</optional>
  </dependency>
- <!-- A planner dependency won't be necessary once FLIP-32 has been completed. -->
- <dependency>
- <groupId>org.apache.flink</groupId>
- <artifactId>flink-table-planner_${scala.binary.version}</artifactId>
- <version>${project.version}</version>
- <scope>provided</scope>
- <optional>true</optional>
- </dependency>
 
  <!-- Test dependencies -->
 
@@ -201,6 +193,12 @@ under the License.
  <version>${project.version}</version>
  <scope>test</scope>
  </dependency>
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-table-planner_${scala.binary.version}</artifactId>
+ <version>${project.version}</version>
+ <scope>test</scope>
+ </dependency>
  <dependency>
  <groupId>org.testcontainers</groupId>
  <artifactId>cassandra</artifactId>

flink-connectors/flink-connector-hive/pom.xml

@@ -888,6 +888,23 @@ under the License.
 
  <build>
  <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-enforcer-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>forbid-direct-table-planner-dependencies</id>
+ <goals>
+ <goal>enforce</goal>
+ </goals>
+ <configuration>
+ <!-- We need to depend on table planner because we rely on its internals -->
+ <skip>true</skip>
+ </configuration>
+ </execution>
+ </executions>
+ </plugin>
+
  <plugin>
  <groupId>org.antlr</groupId>
  <artifactId>antlr3-maven-plugin</artifactId>

flink-dist/pom.xml

@@ -586,6 +586,16 @@ under the License.
  <skip>true</skip>
  </configuration>
  </execution>
+ <execution>
+ <id>forbid-direct-table-planner-dependencies</id>
+ <goals>
+ <goal>enforce</goal>
+ </goals>
+ <configuration>
+ <!-- We need to depend on table planner to ship it in the /opt folder -->
+ <skip>true</skip>
+ </configuration>
+ </execution>
  </executions>
  </plugin>
 

flink-examples/flink-examples-table/pom.xml

@@ -97,6 +97,23 @@ under the License.
 
  <build>
  <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-enforcer-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>forbid-direct-table-planner-dependencies</id>
+ <goals>
+ <goal>enforce</goal>
+ </goals>
+ <configuration>
+ <!-- See comment above on table planner dependency -->
+ <skip>true</skip>
+ </configuration>
+ </execution>
+ </executions>
+ </plugin>
+
  <!-- Fail compilation on deprecation warnings to prevent from showing users outdated examples. -->
  <plugin>
  <groupId>org.apache.maven.plugins</groupId>

flink-table/flink-table-planner-loader-bundle/pom.xml

@@ -31,9 +31,9 @@
  </parent>
 
  <artifactId>flink-table-planner-loader-bundle</artifactId>
- <name>Flink : Table : Planner Loader Helper</name>
+ <name>Flink : Table : Planner Loader Bundle</name>
  <packaging>jar</packaging>
- <description>Intermediate build artifact use by the planner-loader.</description>
+ <description>Intermediate build artifact used by the flink-table-planner-loader.</description>
 
  <dependencies>
  <dependency>
@@ -46,6 +46,22 @@
 
  <build>
  <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-enforcer-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>forbid-direct-table-planner-dependencies</id>
+ <goals>
+ <goal>enforce</goal>
+ </goals>
+ <configuration>
+ <skip>true</skip>
+ </configuration>
+ </execution>
+ </executions>
+ </plugin>
+
  <plugin>
  <groupId>org.apache.maven.plugins</groupId>
  <artifactId>maven-deploy-plugin</artifactId>

pom.xml

@@ -1744,6 +1744,28 @@ under the License.
  </rules>
  </configuration>
  </execution>
+ <execution>
+ <id>forbid-direct-table-planner-dependencies</id>
+ <goals>
+ <goal>enforce</goal>
+ </goals>
+ <configuration>
+ <rules>
+ <bannedDependencies>
+ <excludes>
+ <exclude>org.apache.flink:flink-table-planner_${scala.binary.version}</exclude>
+ </excludes>
+ <includes>
+ <include>org.apache.flink:flink-table-planner_${scala.binary.version}:*:*:test</include>
+ </includes>
+ <message>
+ Direct dependencies on flink-table-planner are not allowed.
+ You should depend on either Table API modules or flink-table-planner-loader.
+ </message>
+ </bannedDependencies>
+ </rules>
+ </configuration>
+ </execution>
  <execution>
  <id>dependency-convergence</id>
  <!-- disabled by default as it interacts badly with shade-plugin -->