Skip to content

Commit

Permalink
[FLINK-7133] Exclude optional asm deps from Elasticsearch base module
Browse files Browse the repository at this point in the history
These ASM dependencies where shaded into the elasticsearch-base module
which where then clashing with our newer (also shaded) ASM dependency.
  • Loading branch information
Adebski authored and aljoscha committed Jul 11, 2017
1 parent d0cc2c1 commit 211d096
Showing 1 changed file with 13 additions and 0 deletions.
13 changes: 13 additions & 0 deletions flink-connectors/flink-connector-elasticsearch-base/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,19 @@ under the License.
<groupId>org.elasticsearch</groupId>
<artifactId>elasticsearch</artifactId>
<version>${elasticsearch.version}</version>
<!--
FLINK-7133: Excluding all org.ow2.asm from elasticsearch dependencies because
1. from the POV of client they are optional,
2. the version configured by default at the time of writing this comment (1.7.1) depends on asm 4.1
and when it is shaded into elasticsearch-base artifact it conflicts with newer shaded versions of asm
resulting in errors at the runtime when application is executed locally, e.g. from IDE.
-->
<exclusions>
<exclusion>
<groupId>org.ow2.asm</groupId>
<artifactId>*</artifactId>
</exclusion>
</exclusions>
</dependency>

<!-- test dependencies -->
Expand Down

0 comments on commit 211d096

Please sign in to comment.