Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New interface #55

Merged
merged 4 commits into from
Oct 27, 2023
Merged

New interface #55

merged 4 commits into from
Oct 27, 2023

Conversation

mayer79
Copy link
Owner

@mayer79 mayer79 commented Oct 27, 2023

This PR solves the old wish to have a more R-like output behaviour of missRanger(): Setting data_only = FALSE will return an object of class "missRanger" with print() and summary() method and a couple of information attached that can be extracted via $.

Furthermore, setting keep_forests = TRUE will attach the random forests used to impute the data.

The PR will solve #54 and #28

@codecov-commenter
Copy link

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (ac24bae) 97.35% compared to head (dce5aea) 93.30%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #55      +/-   ##
==========================================
- Coverage   97.35%   93.30%   -4.06%     
==========================================
  Files           4        5       +1     
  Lines         189      224      +35     
==========================================
+ Hits          184      209      +25     
- Misses          5       15      +10     
Files Coverage Δ
R/methods.R 100.00% <100.00%> (ø)
R/missRanger.R 91.08% <84.05%> (-5.96%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mayer79 mayer79 merged commit 10bd353 into main Oct 27, 2023
7 checks passed
@mayer79 mayer79 deleted the api branch October 27, 2023 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants